From: Andreas Dilger <adilger@clusterfs.com>
To: Cordenner jean noel <jean-noel.cordenner@bull.net>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [RFC] [patch 2/2] i_version update - ext4 part
Date: Mon, 14 May 2007 14:21:48 -0600 [thread overview]
Message-ID: <20070514202148.GE5286@schatzie.adilger.int> (raw)
In-Reply-To: <1179140701.7733.4.camel@frecb002711.frec.bull.fr>
On May 14, 2007 13:05 +0200, Cordenner jean noel wrote:
> @@ -331,12 +331,13 @@
> } osd2; /* OS dependent 2 */
> __le16 i_extra_isize;
> __le16 i_pad1;
> + __le32 i_disk_version_hi;
No, this is not correct. There are already several other fields here
(nanosecond ctime, mtime, atime, crtime (creation time)) so you need
to use the correct reserved field for this.
__u16 i_extra_isize;
__u16 i_pad1;
__u32 i_ctime_extra; /* extra Change time (nsec << 2 | epoch) */
__u32 i_mtime_extra; /* extra Modification time (nsec << 2 | epoch)*/
__u32 i_atime_extra; /* extra Access time (nsec << 2 | epoch) */
__u32 i_crtime; /* File creation time */
__u32 i_crtime_extra; /* extra File creation time (nsec << 2 |epoch)*/
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
next prev parent reply other threads:[~2007-05-14 20:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-14 11:05 [RFC] [patch 2/2] i_version update - ext4 part Cordenner jean noel
2007-05-14 20:21 ` Andreas Dilger [this message]
2007-05-14 20:31 ` Andreas Dilger
2007-05-14 22:11 ` Mingming Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070514202148.GE5286@schatzie.adilger.int \
--to=adilger@clusterfs.com \
--cc=jean-noel.cordenner@bull.net \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).