From: Martin Michlmayr <tbm@cyrius.com>
To: linux-ext4@vger.kernel.org
Subject: Fix section conflict of ext4_ext_{find_goal,invalidate_cache}
Date: Tue, 15 May 2007 19:15:27 +0200 [thread overview]
Message-ID: <20070515171527.GA20407@deprecation.cyrius.com> (raw)
Building with GCC 4.2, I get the following error:
CC [M] fs/ext4/extents.o
fs/ext4/extents.c:2166: error: __ksymtab_ext4_ext_find_goal causes a section type conflict
fs/ext4/extents.c:2163: error: __ksymtab_ext4_ext_invalidate_cache causes a section type conflict
This is because ext4_ext_find_goal and ext4_ext_invalidate_cache are
declared static but also exported.
Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -172,7 +172,7 @@ static int ext4_ext_dirty(handle_t *handle, struct inode *inode,
return err;
}
-static ext4_fsblk_t ext4_ext_find_goal(struct inode *inode,
+ext4_fsblk_t ext4_ext_find_goal(struct inode *inode,
struct ext4_ext_path *path,
ext4_fsblk_t block)
{
--- a/include/linux/ext4_fs_extents.h
+++ b/include/linux/ext4_fs_extents.h
@@ -182,7 +182,7 @@ static inline void ext4_ext_tree_changed(struct inode *inode)
EXT4_I(inode)->i_ext_generation++;
}
-static inline void
+inline void
ext4_ext_invalidate_cache(struct inode *inode)
{
EXT4_I(inode)->i_cached_extent.ec_type = EXT4_EXT_CACHE_NO;
--
Martin Michlmayr
http://www.cyrius.com/
next reply other threads:[~2007-05-15 17:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-15 17:15 Martin Michlmayr [this message]
2007-05-15 18:09 ` Fix section conflict of ext4_ext_{find_goal,invalidate_cache} Badari Pulavarty
2007-05-15 18:59 ` Mingming Cao
2007-05-15 19:06 ` Alex Tomas
2007-05-15 19:08 ` Alex Tomas
2007-05-15 20:43 ` [PATCH] Remove unnecessery exported ext4 symbols Mingming Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070515171527.GA20407@deprecation.cyrius.com \
--to=tbm@cyrius.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).