From: Jan Kara <jack@suse.cz>
To: linux-ext4@vger.kernel.org
Subject: ext2_discard_prealloc() called on each iput?
Date: Tue, 22 May 2007 18:11:27 +0200 [thread overview]
Message-ID: <20070522161127.GC13633@duck.suse.cz> (raw)
Hello,
while fixing some problems with preallocation in UDF, I had a look how
ext2 solves similar problems. I found out that ext2_discard_prealloc() is
called on every iput() from ext2_put_inode(). Is it really appropriate? I
don't see a reason for doing so...
Also I found slightly misleading the comment at ext2_release_file().
As far as I understand the code it isn't when /all/ files are closed but
rather when all fd's for given filp are closed. I.e. if you open the same
file two times, ->release will get called once for each open. Am I right?
If so, then also calling ext2_discard_prealloc() from ext2_release_file()
is suboptimal, isn't it?
Thanks for answer
Honza
--
Jan Kara <jack@suse.cz>
SuSE CR Labs
next reply other threads:[~2007-05-22 16:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-22 16:11 Jan Kara [this message]
2007-05-23 12:37 ` ext2_discard_prealloc() called on each iput? Theodore Tso
2007-05-28 16:04 ` Jan Kara
2007-05-28 16:10 ` Theodore Tso
2007-05-29 21:10 ` Mingming Cao
2007-05-30 9:02 ` Jan Kara
2007-05-29 10:25 ` Jan Kara
2007-05-29 13:16 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070522161127.GC13633@duck.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox