From: Andreas Dilger <adilger@clusterfs.com>
To: Theodore Tso <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] sanity check inode size vs inode ratio
Date: Thu, 24 May 2007 03:38:31 -0600 [thread overview]
Message-ID: <20070524093831.GI5181@schatzie.adilger.int> (raw)
In-Reply-To: <20070522194504.GB4668@thunk.org>
On May 22, 2007 15:45 -0400, Theodore Tso wrote:
> On Mon, May 14, 2007 at 05:03:11PM -0600, Andreas Dilger wrote:
> > A quick patch to sanity check the inode ratio vs the inode size. In some
> > cases Lustre users have tried specifying an inode size of 4096 bytes, while
> > keeping an inode ratio of one inode per 4096 bytes, causing mke2fs to spin
> > forever trying to allocate the inode tables. I'm sure more people will do
> > this now that large inodes are available in ext4 and documented in e2fsprogs.
>
> I can't replicate this. I'm guessing you are doing this with the
> clusterfs codebase that has the extent patches? Mke2fs shouldn't be
> spinning if it can't allocate the inode tables. Instead it should
> print the error message:
Hmm, I suppose it might be due to running this on a 2TB filesystem that is
trying to allocate a huge number of inodes. It could also have been with
an older version of mke2fs - it was a customer that reported the problem.
I just happened to be poking in that bit of code recently and thought I'd
add the sanity check. I don't think it relates to CFS patches, since we
don't change mke2fs at all for the extent code.
We can let it drop for now, until I have a reproducer.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
prev parent reply other threads:[~2007-05-24 9:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-14 23:03 [PATCH] sanity check inode size vs inode ratio Andreas Dilger
2007-05-22 19:45 ` Theodore Tso
2007-05-24 9:38 ` Andreas Dilger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070524093831.GI5181@schatzie.adilger.int \
--to=adilger@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).