Re: ext2_discard_prealloc() called on each iput?

Theodore Tso
2007-05-29T13:16:46Z

On Tue, May 29, 2007 at 12:25:45PM +0200, Jan Kara wrote:
> Fix a comment when ext2_release_file() is called.
>
> Signed-off-by: Jan Kara <jack@suse.cz>

Acked-by: "Theodore Ts'o" <tytso@mit.edu>

> diff -rupX /home/jack/.kerndiffexclude linux-2.6.21/fs/ext2/file.c linux-2.6.21-1-ext2_comment_fix/fs/ext2/file.c
> --- linux-2.6.21/fs/ext2/file.c 2007-05-15 14:18:47.000000000 +0200
> +++ linux-2.6.21-1-ext2_comment_fix/fs/ext2/file.c 2007-05-29 12:15:59.000000000 +0200
> @@ -24,9 +24,9 @@
> #include "acl.h"
>
> /*
> - * Called when an inode is released. Note that this is different
> - * from ext2_open_file: open gets called at every open, but release
> - * gets called only when /all/ the files are closed.
> + * Called when filp is released. This happens when all file descriptors
> + * for a single struct file are closed. Note that different open() calls
> + * for the same file yield different struct file structures.
> */
> static int ext2_release_file (struct inode * inode, struct file * filp)
> {