From: "Jose R. Santos" <jrs@us.ibm.com>
To: Andreas Dilger <adilger@clusterfs.com>
Cc: linux-ext4 <linux-ext4@vger.kernel.org>
Subject: [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks (take 2).
Date: Mon, 4 Jun 2007 11:32:10 -0500 [thread overview]
Message-ID: <20070604113210.1a76934b@gara> (raw)
In-Reply-To: <20070601225441.GF5181@schatzie.adilger.int>
Set the journals JBD2_FEATURE_INCOMPAT_64BIT on devices with more
than 32bit block sizes during mount time. This ensure proper record
lenth when writing to the journal.
Signed-off-by: Jose R. Santos <jrs@us.ibm.com>
---
fs/ext4/super.c | 11 +++++++++++
1 file changed, 11 insertions(+)
Index: linux-2.6.22-rc3/fs/ext4/super.c
===================================================================
--- linux-2.6.22-rc3.orig/fs/ext4/super.c 2007-06-04 11:01:20.028360650 -0500
+++ linux-2.6.22-rc3/fs/ext4/super.c 2007-06-04 11:05:11.389126418 -0500
@@ -1824,6 +1824,17 @@ static int ext4_fill_super (struct super
goto failed_mount3;
}
+ /*
+ * Make sure to set JBD2_FEATURE_INCOMPAT_64BIT on filesystems
+ * with more that 32-bit block counts
+ */
+ if(es->s_blocks_count_hi &&
+ !jbd2_journal_set_features(EXT4_SB(sb)->s_journal, 0, 0,
+ JBD2_FEATURE_INCOMPAT_64BIT)){
+ printk(KERN_ERR "ext4: Failed to set 64-bit journal feature\n");
+ goto failed_mount4;
+ }
+
/* We have now updated the journal if required, so we can
* validate the data journaling mode. */
switch (test_opt(sb, DATA_FLAGS)) {
Thanks
-JRS
next prev parent reply other threads:[~2007-06-04 16:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 15:52 [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks Jose R. Santos
2007-06-01 22:54 ` Andreas Dilger
2007-06-04 16:32 ` Jose R. Santos [this message]
2007-06-04 17:57 ` [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks (take 2) Andreas Dilger
2007-06-04 23:01 ` Mingming Cao
2007-06-04 23:32 ` Andreas Dilger
2007-06-05 11:41 ` Jose R. Santos
2007-06-05 13:14 ` Dave Kleikamp
2007-06-05 13:26 ` Laurent Vivier
2007-06-05 13:49 ` Jose R. Santos
2007-06-05 14:03 ` Laurent Vivier
2007-06-05 15:46 ` Jose R. Santos
2007-06-05 16:07 ` Laurent Vivier
2007-06-05 17:46 ` Mingming Cao
2007-06-05 19:58 ` Jose R. Santos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070604113210.1a76934b@gara \
--to=jrs@us.ibm.com \
--cc=adilger@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox