public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jose R. Santos" <jrs@us.ibm.com>
To: linux-ext4 <linux-ext4@vger.kernel.org>
Subject: [PATCH] JBD2: Change debug file path
Date: Thu, 7 Jun 2007 23:45:37 -0500	[thread overview]
Message-ID: <20070607234537.56537f85@gara> (raw)

The jbd2-debug file used to be located in /proc/sys/fs/jbd2-debug, but
create_proc_entry() does not do lookups on file names with more that one
directory deep.  This causes the entry creation to fail and hence, no proc
file is created.  This patch moves the file to /proc/jbd2-degug.

The file could be move to /proc/fs/jbd2/jbd2-debug, but it would require
some minor alterations to the jbd-stats patch.

This is also broken on the original jbd code.

Signed-off-by: Jose R. Santos <jrs@us.ibm.com>
---
Index: linux-2.6.22-rc3/fs/Kconfig
===================================================================
--- linux-2.6.22-rc3.orig/fs/Kconfig	2007-05-25 21:55:14.000000000 -0500
+++ linux-2.6.22-rc3/fs/Kconfig	2007-06-07 23:17:54.110109520 -0500
@@ -260,10 +260,10 @@ config JBD2_DEBUG
 	  By default, the debugging output will be turned off.
 
 	  If you select Y here, then you will be able to turn on debugging
-	  with "echo N > /proc/sys/fs/jbd2-debug", where N is a number between
+	  with "echo N > /proc/jbd2-debug", where N is a number between
 	  1 and 5. The higher the number, the more debugging output is
 	  generated.  To turn debugging off again, do
-	  "echo 0 > /proc/sys/fs/jbd2-debug".
+	  "echo 0 > /proc/jbd2-debug".
 
 config FS_MBCACHE
 # Meta block cache for Extended Attributes (ext2/ext3/ext4)
Index: linux-2.6.22-rc3/fs/jbd2/journal.c
===================================================================
--- linux-2.6.22-rc3.orig/fs/jbd2/journal.c	2007-06-07 23:10:58.838650182 -0500
+++ linux-2.6.22-rc3/fs/jbd2/journal.c	2007-06-07 23:17:54.113442624 -0500
@@ -2288,7 +2288,7 @@ static int write_jbd_debug(struct file *
 	return count;
 }
 
-#define JBD_PROC_NAME "sys/fs/jbd2-debug"
+#define JBD_PROC_NAME "jbd2-debug"
 
 static void __init create_jbd_proc_entry(void)
 {



-JRS

             reply	other threads:[~2007-06-08  4:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-08  4:45 Jose R. Santos [this message]
2007-06-08  7:08 ` [PATCH] JBD2: Change debug file path Andreas Dilger
2007-06-08 12:01   ` Jose R. Santos
2007-06-09  3:57   ` [PATCH][RFC] JBD2: Use DebugFS for jbd2 debug config option Jose R. Santos
2007-06-11 22:04     ` Mingming Cao
2007-06-11 22:22       ` Jose R. Santos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070607234537.56537f85@gara \
    --to=jrs@us.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox