From: Andreas Dilger <adilger@clusterfs.com>
To: Valerie Clement <valerie.clement@bull.net>
Cc: Theodore Tso <tytso@mit.edu>,
ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [RFC][PATCH 2/12] add new macro EXT2_DESC_PER_BLOCK in e2fsprogs
Date: Mon, 11 Jun 2007 17:23:06 -0600 [thread overview]
Message-ID: <20070611232306.GG5181@schatzie.adilger.int> (raw)
In-Reply-To: <466D7B68.30307@bull.net>
On Jun 11, 2007 18:42 +0200, Valerie Clement wrote:
> +#define EXT2_DESC_PER_BLOCK(s) (EXT2_BLOCK_SIZE(s) / \
> + ((EXT2_SB(s)->s_feature_incompat & EXT4_FEATURE_INCOMPAT_64BIT) ? \
> + sizeof(struct ext4_group_desc) : sizeof(struct ext2_group_desc)))
This should actually use s_desc_size and not "sizeof(struct ext4_group_desc)",
as we may want to increase the size of s_desc_size for some other reason in
the future.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
prev parent reply other threads:[~2007-06-11 23:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-11 16:42 [RFC][PATCH 2/12] add new macro EXT2_DESC_PER_BLOCK in e2fsprogs Valerie Clement
2007-06-11 23:23 ` Andreas Dilger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070611232306.GG5181@schatzie.adilger.int \
--to=adilger@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=valerie.clement@bull.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox