From: Andreas Dilger <adilger@clusterfs.com>
To: Valerie Clement <valerie.clement@bull.net>
Cc: Theodore Tso <tytso@mit.edu>,
ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [RFC][PATCH 7/12] handling of 64-bit block numbers in group desc in e2fsprogs
Date: Tue, 12 Jun 2007 04:05:37 -0600 [thread overview]
Message-ID: <20070612100537.GN5181@schatzie.adilger.int> (raw)
In-Reply-To: <466D7C34.20909@bull.net>
On Jun 11, 2007 18:45 +0200, Valerie Clement wrote:
> +#define EXT2_BLOCK_BITMAP(bg) \
> + ((bg)->bg_block_bitmap + ((__u64)(bg)->bg_block_bitmap_hi << 32))
> +#define EXT2_INODE_BITMAP(bg) \
> + ((bg)->bg_inode_bitmap + ((__u64)(bg)->bg_inode_bitmap_hi << 32))
> +#define EXT2_INODE_TABLE(bg) \
> + ((bg)->bg_inode_table + ((__u64)(bg)->bg_inode_table_hi << 32))
> +
> +
> +#define EXT2_BLOCK_BITMAP(bg) (bg)->bg_block_bitmap
> +#define EXT2_INODE_BITMAP(bg) (bg)->bg_inode_bitmap
> +#define EXT2_INODE_TABLE(bg) (bg)->bg_inode_table
This patch could go straight into e2fsprogs without compatibility problems
if they were properly conditional upon INCOMPAT_64BIT and s_desc_size.
> @@ -95,6 +95,11 @@ void ext2fs_swap_group_desc(struct ext2_
> gdp->bg_flags = ext2fs_swab16(gdp->bg_flags);
> gdp->bg_itable_unused = ext2fs_swab16(gdp->bg_itable_unused);
> gdp->bg_checksum = ext2fs_swab16(gdp->bg_checksum);
> +#ifdef _EXT4FS_
> + gdp->bg_block_bitmap_hi = ext2fs_swab32(gdp->bg_block_bitmap_hi);
> + gdp->bg_inode_bitmap_hi = ext2fs_swab32(gdp->bg_inode_bitmap_hi);
> + gdp->bg_inode_table_hi = ext2fs_swab32(gdp->bg_inode_table_hi);
> +#endif
Same comment.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
prev parent reply other threads:[~2007-06-12 10:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-11 16:45 [RFC][PATCH 7/12] handling of 64-bit block numbers in group desc in e2fsprogs Valerie Clement
2007-06-12 10:05 ` Andreas Dilger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070612100537.GN5181@schatzie.adilger.int \
--to=adilger@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=valerie.clement@bull.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox