From: Andreas Dilger <adilger@clusterfs.com>
To: sho@tnes.nec.co.jp
Cc: linux-ext4@vger.kernel.org
Subject: Re: [RFC][1/4] ext2/3/4: enlarge blocksize
Date: Thu, 21 Jun 2007 16:34:43 -0600 [thread overview]
Message-ID: <20070621223443.GA2178@schatzie.adilger.int> (raw)
In-Reply-To: <20060908131144sho@rifu.tnes.nec.co.jp>
On Sep 08, 2006 13:11 +0900, sho@tnes.nec.co.jp wrote:
> On July 7, 2006, sho wrote:
> These patches support large blocksize up to PAGESIZE (max 64KB).
> NOTE:
> They limit the end of a directory block to 65532(64K - 4)
> to avoid overflow only when using 64KB block.
Takashi, in light of the (very exciting ;-) patches to handle 64kB
PAGE_SIZE on x86 systems, could you please update the large blocksize
patch to the latest ext4 tree?
> diff -upNr -X linux-2.6.18-rc4-mingming/Documentation/dontdiff linux-2.6.18-rc4-mingming/fs/ext2/super.c linux-2.6.18-rc4-mingming-tnes/fs/ext2/super.c
> --- linux-2.6.18-rc4-mingming/fs/ext2/super.c 2006-08-07 03:20:11.000000000 +0900
> +++ linux-2.6.18-rc4-mingming-tnes/fs/ext2/super.c 2006-09-08 09:00:40.000000000 +0900
> @@ -725,7 +725,7 @@ static int ext2_fill_super(struct super_
> brelse(bh);
>
> if (!sb_set_blocksize(sb, blocksize)) {
> - printk(KERN_ERR "EXT2-fs: blocksize too small for device.\n");
> + printk(KERN_ERR "EXT2-fs: bad blocksize %d.\n", blocksize);
> goto failed_sbi;
> }
We need a check in ext2 (like ext3/ext4) to ensure that blocksize <
EXT2_MAX_BLOCK_SIZE. It could be increased to 32768 without danger
I think, only the directory problem prevents it from working with 65536.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
prev parent reply other threads:[~2007-06-21 22:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-08 4:11 [RFC][1/4] ext2/3/4: enlarge blocksize sho
2006-09-08 7:01 ` Updated ext4 patches for 2.6.18-rc6 Mingming Cao
2006-09-08 16:13 ` Alexandre Ratchov
2006-09-08 16:15 ` [patch 1/2] " Alexandre Ratchov
2006-09-08 16:18 ` [patch 2/2] " Alexandre Ratchov
2006-09-08 18:09 ` Andreas Dilger
2007-06-21 22:34 ` Andreas Dilger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070621223443.GA2178@schatzie.adilger.int \
--to=adilger@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sho@tnes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox