Re: [RFC][PATCH 11/11][take 2] 48-bit block number for ACL in e2fsprogs

Andreas Dilger
2007-06-21T22:44:31Z

On Jun 21, 2007 17:49 +0200, Valerie Clement wrote:
> This patch is intended to contain the changes to support 48-bit block
> numbers for ACL. For now, it only contains modifications in the inode
> structure. It has to be completed.
>
> Andreas proposed to rename i_file_acl to i_file_ea
> and i_file_acl_high to i_file_ea_hi.

Yes, it is misleading that these are called "ACL", since the ACL is only
optionally stored internal to the EA block. We should provide compatibility
macros to avoid breaking old code, which will also allow incremental
migration.

> @@ -449,6 +450,7 @@ struct ext2_inode_large {
> #define i_reserved1 osd1.masix1.m_i_reserved1
> #define i_frag osd2.masix2.m_i_frag
> #define i_fsize osd2.masix2.m_i_fsize
> +#define i_file_acl_high osd2.masix2.m_i_file_acl_high
> #define i_reserved2 osd2.masix2.m_i_reserved2

On an unrelated note - does MASIX even exist anymore? I think it was only
a very experimental OS that Rémy Card worked on, and the home page doesn't
even exist anymore.

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.