From: Theodore Tso <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Andreas Dilger <adilger@clusterfs.com>,
linux-ext4@vger.kernel.org, Jim Garlick <garlick@llnl.gov>
Subject: Re: [PATCH] added sanity check for xattr validation
Date: Fri, 22 Jun 2007 02:23:10 -0400 [thread overview]
Message-ID: <20070622062310.GB17097@thunk.org> (raw)
In-Reply-To: <467AE49D.6030207@redhat.com>
On Thu, Jun 21, 2007 at 03:50:37PM -0500, Eric Sandeen wrote:
> Andreas Dilger wrote:
> > Ted,
> > the attached patch adds an extra validity test in check_ext_attr(). If
> > an attribute's e_value_size is zero the current code does not allocate
> > a region for it and as a result the e_value_offs value is not verified.
> > However, if e_value_offs is very large then the later call to
> > ext2fs_ext_attr_hash_entry() can dereference bad memory and crash e2fsck.
>
> Did this patch get lost? Don't see it in Hg...
Thanks, I just committed it.
-Ted
prev parent reply other threads:[~2007-06-22 6:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-26 22:33 [PATCH] added sanity check for xattr validation Andreas Dilger
2007-06-21 20:50 ` Eric Sandeen
2007-06-22 6:23 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070622062310.GB17097@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@clusterfs.com \
--cc=garlick@llnl.gov \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).