From: Theodore Tso <tytso@mit.edu>
To: Kalpak Shah <kalpak@clusterfs.com>
Cc: linux-ext4 <linux-ext4@vger.kernel.org>,
Andreas Dilger <adilger@clusterfs.com>
Subject: Re: [PATCH] Endianness bugs in e2fsck
Date: Fri, 22 Jun 2007 22:34:15 -0400 [thread overview]
Message-ID: <20070623023414.GE22889@thunk.org> (raw)
In-Reply-To: <20070622235432.GC22889@thunk.org>
Also applied into the e2fsprogs tree.
- Ted
# HG changeset patch
# User tytso@mit.edu
# Date 1182565963 14400
# Node ID 98d5fa14e7dedde4754cd42f4d2af2622c4ba3ee
# Parent deeb424beb36d9fb1ff401aca7a5761a451436b8
Fix ext2fs_read_inode_full() so that the whole inode is byte-swapped
Signed-off-by: Kalpak Shah <kalpak@clusterfs.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
diff -r deeb424beb36 -r 98d5fa14e7de lib/ext2fs/ChangeLog
--- a/lib/ext2fs/ChangeLog Fri Jun 22 19:53:21 2007 -0400
+++ b/lib/ext2fs/ChangeLog Fri Jun 22 22:32:43 2007 -0400
@@ -1,4 +1,7 @@ 2007-06-22 Theodore Tso <tytso@mit.edu
2007-06-22 Theodore Tso <tytso@mit.edu>
+
+ * inode.c (ext2fs_read_inode_full): Pass in bufsize so the full
+ inode is byte-swapped.
* swapfs.c (ext2fs_swap_inode_full): Fix byte-swapping issues for
i_extra_size field.
diff -r deeb424beb36 -r 98d5fa14e7de lib/ext2fs/inode.c
--- a/lib/ext2fs/inode.c Fri Jun 22 19:53:21 2007 -0400
+++ b/lib/ext2fs/inode.c Fri Jun 22 22:32:43 2007 -0400
@@ -586,7 +586,7 @@ errcode_t ext2fs_read_inode_full(ext2_fi
(fs->flags & EXT2_FLAG_SWAP_BYTES_READ))
ext2fs_swap_inode_full(fs, (struct ext2_inode_large *) inode,
(struct ext2_inode_large *) inode,
- 0, length);
+ 0, bufsize);
#endif
/* Update the inode cache */
next prev parent reply other threads:[~2007-06-23 2:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-20 9:33 [PATCH] Endianness bugs in e2fsck Kalpak Shah
2007-06-20 15:09 ` Theodore Tso
2007-06-20 19:36 ` Kalpak Shah
2007-06-22 22:20 ` Theodore Tso
2007-06-22 23:54 ` Theodore Tso
2007-06-23 2:34 ` Theodore Tso [this message]
2007-06-23 0:36 ` Theodore Tso
2007-06-25 8:13 ` Kalpak Shah
2007-07-17 21:19 ` Eric Sandeen
2007-07-18 1:40 ` Eric Sandeen
2007-07-18 7:04 ` Kalpak Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070623023414.GE22889@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@clusterfs.com \
--cc=kalpak@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox