From: Andreas Dilger <adilger@clusterfs.com>
To: "Amit K. Arora" <aarora@linux.vnet.ibm.com>
Cc: Theodore Ts'o <tytso@mit.edu>, linux-ext4@vger.kernel.org
Subject: Re: ext4-patch-queue rebased to 2.6.22
Date: Tue, 10 Jul 2007 14:26:45 -0600 [thread overview]
Message-ID: <20070710202645.GC6417@schatzie.adilger.int> (raw)
In-Reply-To: <20070710175558.GA15345@amitarora.in.ibm.com>
On Jul 10, 2007 23:25 +0530, Amit K. Arora wrote:
> On Tue, Jul 10, 2007 at 11:09:39AM -0600, Andreas Dilger wrote:
> > It might even make sense to change the other #define to be called
> > EXT_INIT_MAX_LEN so people have to think about this when using the #define.
>
> Done. Changes are in ext4 patch queue.
> Can you please have a quick look and see if this is what you preferred ?
Yes, it looks good, though I wonder if it also makes sense to change the
ext4_ext_*_uninitialized() code to use EXT_INIT_MAX_LEN instead of 0x8000,
since that makes it a bit clearer that the two are related.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
prev parent reply other threads:[~2007-07-10 20:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-09 17:37 ext4-patch-queue rebased to 2.6.22 Theodore Ts'o
2007-07-09 21:15 ` Mingming Cao
2007-07-10 14:54 ` Amit K. Arora
2007-07-10 17:09 ` Andreas Dilger
2007-07-10 17:55 ` Amit K. Arora
2007-07-10 20:26 ` Andreas Dilger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070710202645.GC6417@schatzie.adilger.int \
--to=adilger@clusterfs.com \
--cc=aarora@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).