From: "Jose R. Santos" <jrs@us.ibm.com>
To: Andreas Dilger <adilger@clusterfs.com>
Cc: Theodore Tso <tytso@mit.edu>, linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: Initial results of FLEX_BG feature.
Date: Mon, 16 Jul 2007 07:27:18 -0500 [thread overview]
Message-ID: <20070716072718.339551e0@gara> (raw)
In-Reply-To: <20070716063457.GA5992@schatzie.adilger.int>
On Mon, 16 Jul 2007 00:34:57 -0600
Andreas Dilger <adilger@clusterfs.com> wrote:
> On Jul 12, 2007 10:09 -0500, Jose R. Santos wrote:
> > @@ -1271,6 +1271,9 @@ static int ext4_check_descriptors (struc
> >
> > ext4_debug ("Checking group descriptors");
> >
> > + if (EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_FLEX_BG))
> > + return 1;
> > +
> > for (i = 0; i < sbi->s_groups_count; i++)
> > {
> > if (i == sbi->s_groups_count - 1)
>
> It looks pretty straight forward to just change this code to leave
> first_block at s_first_data_block, and leave last_block at ext4_blocks_count()
> if FLEX_BG is set.
Sure. I'll add that.
> Even with FLEX_BG we want to keep the group metadata within the bounds of
> the filesystem.
Eventually, I want to be able to export the groups per flex groups so
that we can correctly calculate where the bounds of each block groups
metadata should be.
> Cheers, Andreas
> --
> Andreas Dilger
> Principal Software Engineer
> Cluster File Systems, Inc.
>
-JRS
prev parent reply other threads:[~2007-07-16 12:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-10 16:23 Initial results of FLEX_BG feature Jose R. Santos
2007-07-11 4:12 ` Andreas Dilger
2007-07-11 5:30 ` Jose R. Santos
2007-07-11 5:39 ` Eric Sandeen
2007-07-11 12:41 ` Andreas Dilger
2007-07-11 22:09 ` Theodore Tso
2007-07-11 22:14 ` Theodore Tso
2007-07-12 15:02 ` Jose R. Santos
2007-07-12 15:09 ` Jose R. Santos
2007-07-16 6:34 ` Andreas Dilger
2007-07-16 12:27 ` Jose R. Santos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070716072718.339551e0@gara \
--to=jrs@us.ibm.com \
--cc=adilger@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).