From: "Jose R. Santos" <jrs@us.ibm.com>
To: linux-ext4@vger.kernel.org
Subject: [PATCH][e2fsprogs] Move ext2fs_struct_generic_bitmap back into ext2fs.h
Date: Tue, 07 Aug 2007 16:16:39 -0500 [thread overview]
Message-ID: <20070807211639.22127.99361.stgit@rx8> (raw)
From: Jose R. Santos <jrs@us.ibm.com>
Move ext2fs_struct_generic_bitmap back into ext2fs.h
In Commit: f1f115a78f5ea599fc5f8815a741d43fedd5840d
The ext2fs_struct_generic_bitmap structure is remove from ext2fs.h and
put into gen_bitmap.c. This breaks big endian compiles since swapfs.c
uses this structure as well if EXT2_BIG_ENDIAN_BITMAPS is defined.
Since we have multiple users, this patch move
ext2fs_struct_generic_bitmap back into ext2fs.h in order to compile on
PowerPC or other big endian archs.
Signed-off-by: Jose R. Santos <jrs@us.ibm.com>
--
lib/ext2fs/ext2fs.h | 11 +++++++++++
lib/ext2fs/gen_bitmap.c | 11 -----------
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/lib/ext2fs/ext2fs.h b/lib/ext2fs/ext2fs.h
index d1cda2f..f34d2f9 100644
--- a/lib/ext2fs/ext2fs.h
+++ b/lib/ext2fs/ext2fs.h
@@ -100,6 +100,17 @@ typedef __u32 ext2_dirhash_t;
typedef struct struct_ext2_filsys *ext2_filsys;
+struct ext2fs_struct_generic_bitmap {
+ errcode_t magic;
+ ext2_filsys fs;
+ __u32 start, end;
+ __u32 real_end;
+ char * description;
+ char * bitmap;
+ errcode_t base_error_code;
+ __u32 reserved[7];
+};
+
#define EXT2FS_MARK_ERROR 0
#define EXT2FS_UNMARK_ERROR 1
#define EXT2FS_TEST_ERROR 2
diff --git a/lib/ext2fs/gen_bitmap.c b/lib/ext2fs/gen_bitmap.c
index 66172e5..3d01149 100644
--- a/lib/ext2fs/gen_bitmap.c
+++ b/lib/ext2fs/gen_bitmap.c
@@ -27,17 +27,6 @@
#include "ext2_fs.h"
#include "ext2fs.h"
-struct ext2fs_struct_generic_bitmap {
- errcode_t magic;
- ext2_filsys fs;
- __u32 start, end;
- __u32 real_end;
- char * description;
- char * bitmap;
- errcode_t base_error_code;
- __u32 reserved[7];
-};
-
/*
* Used by previously inlined function, so we have to export this and
* not change the function signature
next reply other threads:[~2007-08-07 21:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-07 21:16 Jose R. Santos [this message]
2007-08-09 21:42 ` [PATCH][e2fsprogs] Move ext2fs_struct_generic_bitmap back into ext2fs.h Theodore Tso
2007-08-12 16:57 ` Theodore Ts'o
2007-08-12 16:57 ` [PATCH] Remove e2fsck's -s and -S options to byte-swap ancient PPC filesystems Theodore Ts'o
2007-08-12 16:57 ` [PATCH] Remove e2fsck's swapfs test, since we've removed the functionality Theodore Ts'o
2007-08-12 16:57 ` [PATCH] Remove PowerPC bitmap hackery since it's not been needed since Linux 2.1 Theodore Ts'o
2007-08-12 16:57 ` [PATCH] Clean up libext2fs by byte swapping iff WORDS_BIGENDIAN Theodore Ts'o
2007-08-12 16:57 ` [PATCH] Clean up applications to not use EXT2FS_ENABLE_SWAPFS or EXT2_FLAG_SWAP_BYTES Theodore Ts'o
2007-08-12 16:57 ` [PATCH] Remove configure --enable-swapfs and associated support #defines Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070807211639.22127.99361.stgit@rx8 \
--to=jrs@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox