From: Theodore Tso <tytso@mit.edu>
To: "Jose R. Santos" <jrs@us.ibm.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH][e2fsprogs] Move ext2fs_struct_generic_bitmap back into ext2fs.h
Date: Thu, 9 Aug 2007 17:42:54 -0400 [thread overview]
Message-ID: <20070809214254.GB5438@thunk.org> (raw)
In-Reply-To: <20070807211639.22127.99361.stgit@rx8>
On Tue, Aug 07, 2007 at 04:16:39PM -0500, Jose R. Santos wrote:
> From: Jose R. Santos <jrs@us.ibm.com>
>
> Move ext2fs_struct_generic_bitmap back into ext2fs.h
>
> In Commit: f1f115a78f5ea599fc5f8815a741d43fedd5840d
>
> The ext2fs_struct_generic_bitmap structure is remove from ext2fs.h and
> put into gen_bitmap.c. This breaks big endian compiles since swapfs.c
> uses this structure as well if EXT2_BIG_ENDIAN_BITMAPS is defined.
Actually, it's rw_bitmaps.c, and I don't want to do this because this
is part of the cleanups where I am trying to localize code that knows
about the in-memory encoding of bitmaps.
It turns out the need for this was only in the very first ports of
Linux to the Powerpc, and there haven't been kernels that would mount
big-endian superblocks since, oh, 1998 or so (in the 2.0 days).
So probably the better fix is one where we don't allow big-endian
filesystems any more. On all modern systems, we use little-endian
encoding of the superblock, and the bitmaps don't need byte-swapping.
- Ted
next prev parent reply other threads:[~2007-08-10 13:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-07 21:16 [PATCH][e2fsprogs] Move ext2fs_struct_generic_bitmap back into ext2fs.h Jose R. Santos
2007-08-09 21:42 ` Theodore Tso [this message]
2007-08-12 16:57 ` Theodore Ts'o
2007-08-12 16:57 ` [PATCH] Remove e2fsck's -s and -S options to byte-swap ancient PPC filesystems Theodore Ts'o
2007-08-12 16:57 ` [PATCH] Remove e2fsck's swapfs test, since we've removed the functionality Theodore Ts'o
2007-08-12 16:57 ` [PATCH] Remove PowerPC bitmap hackery since it's not been needed since Linux 2.1 Theodore Ts'o
2007-08-12 16:57 ` [PATCH] Clean up libext2fs by byte swapping iff WORDS_BIGENDIAN Theodore Ts'o
2007-08-12 16:57 ` [PATCH] Clean up applications to not use EXT2FS_ENABLE_SWAPFS or EXT2_FLAG_SWAP_BYTES Theodore Ts'o
2007-08-12 16:57 ` [PATCH] Remove configure --enable-swapfs and associated support #defines Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070809214254.GB5438@thunk.org \
--to=tytso@mit.edu \
--cc=jrs@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).