linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Alex Tomas <alex@clusterfs.com>
Cc: "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: [ext3][kernels >= 2.6.20.7 at least] KDE going comatose when FS is under heavy write load (massive starvation)
Date: Thu, 16 Aug 2007 11:46:05 -0700	[thread overview]
Message-ID: <20070816114605.5a233c7e.akpm@linux-foundation.org> (raw)
In-Reply-To: <46C49556.4000409@clusterfs.com>

On Thu, 16 Aug 2007 22:20:06 +0400
Alex Tomas <alex@clusterfs.com> wrote:

> Andrew Morton wrote:
> >>> But under this proposal, t_sync_datalist just gets removed: the new
> >>> ordered-data mode _only_ need to do the sb->inode->page walk.  So if I'm
> >>> understanding you, the way in which we'd handle any such race is to make
> >>> kjournald's writeback of the dirty pages block in lock_page().  Once it
> >>> gets the page lock it can look to see if some other thread has mapped the
> >>> page to disk.
> >> if I'm right holding number of pages locked, then they won't be locked, but
> >> writeback. of course kjournald can block on writeback as well, but how does
> >> it find pages with *newly allocated* blocks only?
> > 
> > I don't think we'd want kjournald to do that.  Even if a page was dirtied
> > by an overwrite, we'd want to write it back during commit, just from a
> > quality-of-implementation point of view.  If we were to leave these pages
> > unwritten during commit then a post-recovery file could have a mix of
> > up-to-five-second-old data and up-to-30-seconds-old data.
> 
> trying to implement this I've got to think that there is one significant
> difference between t_sync_datalist and sb->inode->page walk: t_sync_datalist
> is per-transaction. IOW, it doesn't change once transaction is closed. in
> contrast, nothing (currently) would prevent others to modify pages while
> commit is in progress.

That can happen at present - there's nothing to stop a process from modifying
a page which is undergoing ordered-data commit-time writeout.

  reply	other threads:[~2007-08-16 18:46 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1177660767.6567.41.camel@Homer.simpson.net>
2007-04-27  8:33 ` [ext3][kernels >= 2.6.20.7 at least] KDE going comatose when FS is under heavy write load (massive starvation) Andrew Morton
2007-04-27  9:23   ` Mike Galbraith
2007-04-27 10:17   ` Mike Galbraith
2007-04-27 11:59   ` Marat Buharov
2007-04-27 12:30     ` Peter Zijlstra
2007-04-27 13:50       ` Mark Lord
2007-04-27 12:39     ` Manoj Joseph
2007-04-27 15:30     ` Linus Torvalds
2007-04-27 19:31       ` Andreas Dilger
2007-04-27 19:44         ` Mike Galbraith
2007-04-27 19:50         ` Linus Torvalds
2007-04-27 20:05           ` Hua Zhong
2007-04-27 20:12           ` Bill Huey
2007-04-28  5:37             ` Mikulas Patocka
2007-04-28  5:45               ` Mikulas Patocka
2007-04-28 21:57               ` Bill Huey
2007-04-28 22:38                 ` Mikulas Patocka
2007-04-27 20:29           ` Gabriel C
2007-04-27 20:54           ` Manoj Joseph
2007-04-28  8:45           ` Matthias Andree
2007-04-27 22:18         ` Andrew Morton
2007-05-03 17:38           ` Alex Tomas
2007-05-03 23:54             ` Andrew Morton
2007-05-04  6:18               ` Alex Tomas
2007-05-04  6:38                 ` Andrew Morton
2007-05-04  6:57                   ` Alex Tomas
2007-05-04  7:18                     ` Andrew Morton
2007-05-04  7:39                       ` Alex Tomas
2007-05-04  8:02                         ` Andrew Morton
2007-08-16 18:20                           ` Alex Tomas
2007-08-16 18:46                             ` Andrew Morton [this message]
2007-08-17  2:24                               ` Alex Tomas
2007-08-17  6:52                                 ` Andrew Morton
2007-08-17  8:36                                   ` Alex Tomas
2007-08-17  9:02                                     ` Andrew Morton
2007-08-17 18:42                                       ` Alex Tomas
2007-04-28  8:44       ` Matthias Andree
2007-04-28 20:46   ` Mikulas Patocka
2007-04-28 21:12     ` Lee Revell
2007-04-29 20:49       ` Mark Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070816114605.5a233c7e.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=alex@clusterfs.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).