From: Theodore Tso <tytso@mit.edu>
To: "Jose R. Santos" <jrs@us.ibm.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 01/13][e2fsprogs] Add initial checksum support.
Date: Sun, 14 Oct 2007 22:46:05 -0400 [thread overview]
Message-ID: <20071015024605.GA21216@thunk.org> (raw)
In-Reply-To: <20071011191605.4599.34407.stgit@gara>
In crc16.h, this patch assumes that linux/types.h defines uint16_t.
There are a couple of problems with this.
#1) linux/types.h is non-portable, not only does it not exist on
non-Linux systems, apparently on Ubuntu it's not always defining
uint16_t. On my Ubuntu gutsy system, it doesn't always get defined.
CC ../../../lib/ext2fs/crc16.c
In file included from ../../../lib/ext2fs/crc16.c:10:
../../../lib/ext2fs/crc16.h:20: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘const’
../../../lib/ext2fs/crc16.h:22: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘crc16’
The right thing to do is to use ext2fs/ext2_types.h like everything
else in e2fsprogs, and use __u16 instead of uint16_t.
- Ted
next prev parent reply other threads:[~2007-10-15 2:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 19:15 [PATCH 00/13][e2fsprogs] Uninit block group break down Jose R. Santos
2007-10-11 19:16 ` [PATCH 01/13][e2fsprogs] Add initial checksum support Jose R. Santos
2007-10-15 2:46 ` Theodore Tso [this message]
2007-10-15 9:43 ` Jose R. Santos
2007-10-15 11:55 ` Theodore Tso
2007-11-13 23:04 ` Karel Zak
2007-10-15 20:53 ` Theodore Tso
2007-10-11 19:16 ` [PATCH 02/13][e2fsprogs] Add uninit block group support on libe2fs Jose R. Santos
2007-10-11 19:16 ` [PATCH 03/13][e2fsprogs] Rename feature name from gdt_checksum to uninit_groups Jose R. Santos
2007-10-11 19:16 ` [PATCH 04/13][e2fsprogs] Add support for creating filesystems using uninit block group Jose R. Santos
2007-10-11 19:16 ` [PATCH 05/13][e2fsprogs] Make tune2fs uninit block group aware Jose R. Santos
2007-10-11 19:16 ` [PATCH 06/13][e2fsprogs] Make dumpe2fs " Jose R. Santos
2007-10-11 19:16 ` [PATCH 07/13][e2fsprogs] Make resize2fs " Jose R. Santos
2007-10-11 19:16 ` [PATCH 08/13][e2fsprogs] Make debugfs " Jose R. Santos
2007-10-11 19:16 ` [PATCH 09/13][e2fsprogs] Make e2fsck " Jose R. Santos
2007-10-11 19:17 ` [PATCH 10/13][e2fsprogs] Update uninit block group documetation for some of the utilities Jose R. Santos
2007-10-11 19:17 ` [PATCH 11/13][e2fsprogs] Fix test cases Jose R. Santos
2007-10-11 19:17 ` [PATCH 12/13][e2fsprogs] Add new mm_lazy test case Jose R. Santos
2007-10-11 19:17 ` [PATCH 13/13][e2fsprogs] Add m_uninit " Jose R. Santos
2007-11-01 9:48 ` Coly Li
2007-11-01 9:58 ` Coly Li
2007-11-01 11:03 ` Jose R. Santos
2007-11-01 11:26 ` Jose R. Santos
2007-11-01 12:11 ` Coly Li
2007-11-01 12:10 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071015024605.GA21216@thunk.org \
--to=tytso@mit.edu \
--cc=jrs@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).