From: Theodore Tso <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH e2fsprogs] return status from chattr
Date: Mon, 22 Oct 2007 08:55:04 -0400 [thread overview]
Message-ID: <20071022125504.GB29220@thunk.org> (raw)
In-Reply-To: <4718FD8B.5050803@redhat.com>
On Fri, Oct 19, 2007 at 01:55:07PM -0500, Eric Sandeen wrote:
> Eric Sandeen wrote:
> > This is for RH bug #180596, Chattr command doesn't provide expected
> > exit code in case of failure.
> >
> > (trying to clear out an e2fsprogs bug backlog, can you tell?) :)
>
> Any comments on this one? Can we commit it if it looks ok?
It turns out you didn't quite completely fix the problem, since the
iterate_on_directory() command wasn't reflecting errors up.
Also, while I was at it I cleaned up the code so that it more it
attempts to set the flags on special files, instead of just ignoring
them. On Linux this will result in an error message, but at least
this way the user knows that those files didn't get set, and you can
suppress them using the -f flag, just like chmod/chown.
- Ted
next prev parent reply other threads:[~2007-10-22 12:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-20 17:57 [PATCH e2fsprogs] return status from chattr Eric Sandeen
2007-10-19 18:55 ` Eric Sandeen
2007-10-22 12:55 ` Theodore Tso [this message]
2007-10-22 13:30 ` [PATCH] libe2p: Use lstat() instead of stat() in fsetflags() and fgetflags() Theodore Ts'o
2007-10-22 13:30 ` [PATCH] libe2p: Change iterate_on_dir so that it counts non-zero returns Theodore Ts'o
2007-10-22 13:30 ` [PATCH] chattr: provide an exit code in case of failure and add -f flag Theodore Ts'o
2007-10-22 5:27 ` [PATCH e2fsprogs] return status from chattr Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071022125504.GB29220@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).