From: Andreas Dilger <adilger@sun.com>
To: Mingming Cao <cmm@us.ibm.com>
Cc: Girish Shilamkar <girish@clusterfs.com>,
Avantika Mathur <mathur@linux.vnet.ibm.com>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH][RFC]JBD2: Fix journal checksum kernel oops on NUMA
Date: Fri, 2 Nov 2007 13:20:31 +0800 [thread overview]
Message-ID: <20071102052031.GC18505@webber.adilger.int> (raw)
In-Reply-To: <1193964035.4014.23.camel@localhost.localdomain>
On Nov 01, 2007 17:40 -0700, Mingming Cao wrote:
> Current journal checksumming patch failed fsstress test on NUMA. The
> bh->b_data passed to the crc32_be () function could be NULL pointer,
> which caused kernel oops immediately when running fsstress with -o
> journal_checksum. It is because the page is part of highmem on NUMA box.
> We need to kmap the page before access the bh->b_data to calculate
> the checksums.
I have no objection to the patch, per-se, but I'm surprised that there
would ever be a buffer head pointing at a page in high memory? That
seems contrary to what I would expect...
Cheers, Andreas
--
Andreas Dilger
Sr. Software Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
next prev parent reply other threads:[~2007-11-02 5:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-30 18:16 jbd2_journal_commit_transaction oops Avantika Mathur
2007-08-31 9:21 ` Girish Shilamkar
2007-08-31 21:32 ` Avantika Mathur
2007-09-13 9:49 ` Girish Shilamkar
2007-11-02 0:40 ` [PATCH][RFC]JBD2: Fix journal checksum kernel oops on NUMA Mingming Cao
2007-11-02 5:20 ` Andreas Dilger [this message]
2007-11-02 16:31 ` Badari Pulavarty
2007-11-03 1:36 ` Andreas Dilger
2007-11-05 16:04 ` Badari Pulavarty
2007-11-05 16:15 ` Andreas Dilger
2007-11-05 18:07 ` Badari Pulavarty
2007-11-05 23:21 ` Mingming Cao
2007-11-06 1:33 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071102052031.GC18505@webber.adilger.int \
--to=adilger@sun.com \
--cc=cmm@us.ibm.com \
--cc=girish@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
--cc=mathur@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).