linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>, twoerner@redhat.com
Subject: Re: [PATCH/RFC e2fsprogs] - replace MKINSTALLDIRS with MKDIR_P for newer autotools
Date: Sat, 10 Nov 2007 18:25:39 -0500	[thread overview]
Message-ID: <20071110232539.GA12991@thunk.org> (raw)
In-Reply-To: <472F9148.1050405@redhat.com>

On Mon, Nov 05, 2007 at 03:55:20PM -0600, Eric Sandeen wrote:
> From: Thomas Woerner <twoerner@redhat.com <mailto:twoerner@redhat.com>>
> 
> (Thomas was the original author of this patch)
> 
> I do not claim to be an autotools guru, hence the RFC.
> RH bugzilla #220715 claims that newer autoconf/automake no longer
> support MKINSTALLDIRS, and the changelog seems to confirm that, as
> does testing.  :)


MKINSTALLDIRS is defined in aclocal.m4, so we're good.  This patch
isn't necessary, as far as I can tell.  Have you actually shown that
with some newer version of autoconf, it produces a configure script
which doesn't define MKINSTALLDIRS?  As far as I know e2fsprogs builds
Just Fine, and using autoconf 2.61 isn't a problem.

What version of autoconf are you using that triggers this problem?
(Note that e2fsprogs does not use automake, since automake is a
horrible kludge of backwards non-compatibility and ugliness....)

At some point when we go to a newer version of gettext we may need to
update things, but I'd much rather save that for when we really uplift
gettext and aclocal.m4 all in one go.

For now, I suspect you could drop this patch without any problems,
since we don't use automake, and aclocal.m4 has a version of
AM_MKINSTALLDIRS that will do the right thing.

Regards,

						- Ted

      reply	other threads:[~2007-11-11  0:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-05 21:55 [PATCH/RFC e2fsprogs] - replace MKINSTALLDIRS with MKDIR_P for newer autotools Eric Sandeen
2007-11-10 23:25 ` Theodore Tso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071110232539.GA12991@thunk.org \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=twoerner@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).