From: Andrew Morton <akpm@linux-foundation.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Introduce ext4_find_next_bit
Date: Mon, 12 Nov 2007 23:59:10 -0800 [thread overview]
Message-ID: <20071112235910.35a635e4.akpm@linux-foundation.org> (raw)
In-Reply-To: <11903523063349-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
On Fri, 21 Sep 2007 10:55:05 +0530 "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
> Also add generic_find_next_le_bit
>
> This gets used by the ext4 multi block allocator patches.
>
arm allmodconfig:
fs/ext4/mballoc.c: In function `ext4_mb_generate_buddy':
fs/ext4/mballoc.c:836: error: implicit declaration of function `ext2_find_next_bit'
This patch makes my head spin.
Why did we declare generic_find_next_le_bit() in
include/asm-powerpc/bitops.h (wrong) as well as in
include/asm-generic/bitops/le.h (presumably correct)?
Why is it touching a powerpc file and no any other architectures?
Something screwed up in powerpc land?
And why did arm break?
Shudder. Anyway, please fix, and if that fix requires that various
braindamaged be repaired, please repair the braindamage rather than going
along with it.
Thanks.
next prev parent reply other threads:[~2007-11-13 7:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 5:25 [PATCH] Introduce ext4_find_next_bit Aneesh Kumar K.V
2007-09-21 5:25 ` [PATCH] ext4: Fix spare warnings Aneesh Kumar K.V
2007-09-21 6:02 ` Balbir Singh
2007-09-21 9:04 ` Aneesh Kumar K.V
2007-09-21 6:43 ` [PATCH] Introduce ext4_find_next_bit Balbir Singh
2007-09-21 9:08 ` Aneesh Kumar K.V
2007-11-13 7:59 ` Andrew Morton [this message]
2007-11-13 19:11 ` Aneesh Kumar K.V
2007-11-13 20:43 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071112235910.35a635e4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).