From: Jan Kara <jack@suse.cz>
To: Theodore Tso <tytso@MIT.EDU>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH resend] Fix reading of bitmaps from filesystem image
Date: Mon, 14 Jan 2008 17:17:29 +0100 [thread overview]
Message-ID: <20080114161729.GF4214@duck.suse.cz> (raw)
In-Reply-To: <20080114155718.GC25813@mit.edu>
On Mon 14-01-08 10:57:18, Theodore Tso wrote:
> On Wed, Jan 09, 2008 at 08:54:35PM +0100, Jan Kara wrote:
> >
> > Reading of bitmaps from image file could never work with more than one
> > group in a filesystem... Fix the loops so that we read appropriate number
> > of blocks.
>
> OK, so I'm probably being dense, but.... what's the problem?
>
> You changed the loop from counting in bytes to inodes, but either
> method should work.
At the beginning of read_bitmap() there is:
unsigned int block_nbytes = EXT2_BLOCKS_PER_GROUP(fs->super) / 8;
unsigned inode_nbytes = EXT2_INODES_PER_GROUP(fs->super) / 8;
Therefore in the loop:
while (inode_nbytes > 0)
we end up reading bitmap for just one group...
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2008-01-14 16:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-09 19:54 [PATCH resend] Fix reading of bitmaps from filesystem image Jan Kara
2008-01-14 15:57 ` Theodore Tso
2008-01-14 16:17 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080114161729.GF4214@duck.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox