Re: [PATCH] Do not try lock_acquire after handle made invalid

[Andrew Morton <akpm@linux-foundation.org>]

On Wed, 16 Jan 2008 00:39:26 +0100
Jonas Bonn <jonas.bonn@gmail.com> wrote:

> This likely fixes the oops in __lock_acquire reported as:
> 
> http://www.kerneloops.org/raw.php?rawid=2753&msgid=
> http://www.kerneloops.org/raw.php?rawid=2749&msgid=
> 
> In these reported oopses, start_this_handle is returning -EROFS.
> 
> Signed-off-by: Jonas Bonn <jonas.bonn@gmail.com>
> ---
>  fs/jbd/transaction.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
> index 08ff6c7..038ed74 100644
> --- a/fs/jbd/transaction.c
> +++ b/fs/jbd/transaction.c
> @@ -288,10 +288,12 @@ handle_t *journal_start(journal_t *journal, int nblocks)
>  		jbd_free_handle(handle);
>  		current->journal_info = NULL;
>  		handle = ERR_PTR(err);
> +		goto out;
>  	}
>  
>  	lock_acquire(&handle->h_lockdep_map, 0, 0, 0, 2, _THIS_IP_);
>  
> +out:
>  	return handle;
>  }

Yeah, thanks.

It looks like we forgot to port this lockdep support into ext4.  This is
bad.  What else got lost?