From: Arnd Bergmann <arnd@arndb.de>
To: Mathieu Segaud <mathieu.segaud@regala.cx>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, sct@redhat.com
Subject: Re: [PATCH] Convert EXT2 to use unlocked_ioctl
Date: Thu, 17 Jan 2008 12:54:03 +0100 [thread overview]
Message-ID: <200801171254.04071.arnd@arndb.de> (raw)
In-Reply-To: <1200565824-362-1-git-send-email-mathieu.segaud@regala.cx>
On Thursday 17 January 2008, you wrote:
>
> Change ext_ioctl() to be an unlocked_ioctl(), explicitly
> exposing BKL's uses.
>
> Signed-off-by: Mathieu Segaud <mathieu.segaud@regala.cx>
You are now calling lock_kernel() twice in case of ext2_compat_ioctl(),
which calls back into ext2_ioctl with the BKL already held.
This is allowed with the BKL, but really bad style that you should
avoid. I assume the ext3 and ext4dev versions of your patch have
the same issue, but I didn't check in detail.
Arnd <><
next prev parent reply other threads:[~2008-01-17 11:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-17 10:30 [PATCH] Convert EXT2 to use unlocked_ioctl Mathieu Segaud
2008-01-17 10:30 ` [PATCH] Convert ext3_ioctl() to an unlocked_ioctl Mathieu Segaud
2008-01-17 10:30 ` [PATCH] Convert ext4_ioctl " Mathieu Segaud
2008-01-17 11:54 ` Arnd Bergmann [this message]
2008-01-17 11:59 ` [PATCH] Convert EXT2 to use unlocked_ioctl Mathieu SEGAUD
2008-01-17 12:12 ` Mathieu SEGAUD
2008-01-17 12:18 ` Arnd Bergmann
2008-01-17 12:26 ` Mathieu SEGAUD
-- strict thread matches above, loose matches on Subject: below --
2008-01-17 12:37 Mathieu Segaud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801171254.04071.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.segaud@regala.cx \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox