Re: [PATCH 23/49] Add buffer head related helper functions

Andrew Morton
2008-01-24T08:54:27Z

> On Thu, 24 Jan 2008 10:52:27 +0530 "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
> + * Returns zero on success and -EIO on error.If the input
> + * buffer is not locked returns -EINVAL
> + *
> + */
> +int bh_submit_read(struct buffer_head *bh)
> +{
> + if (!buffer_locked(bh))
> + return -EINVAL;

Is this case just catching a programming bug?

If so, a plain old BUG_ON would be better.