* [PATCH] Handle unusual results from find_tempdir.
@ 2008-02-05 12:13 Jim Meyering
2008-02-05 15:35 ` Theodore Tso
0 siblings, 1 reply; 2+ messages in thread
From: Jim Meyering @ 2008-02-05 12:13 UTC (permalink / raw)
To: linux-ext4
An alternative: make find_tempdir set tempdir to default_tempdir
upon malloc failure.
* arch/um/os-Linux/mem.c (make_tempfile): Handle NULL tempdir.
Don't let a long tempdir (e.g., via TMPDIR) provoke heap corruption.
Signed-off-by: Jim Meyering <meyering@redhat.com>
---
arch/um/os-Linux/mem.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/um/os-Linux/mem.c b/arch/um/os-Linux/mem.c
index e114d09..1458385 100644
--- a/arch/um/os-Linux/mem.c
+++ b/arch/um/os-Linux/mem.c
@@ -176,6 +176,9 @@ int __init make_tempfile(const char *template, char **out_tempname,
return -1;
find_tempdir();
+ if (tempdir == NULL || strlen(tempdir) >= MAXPATHLEN)
+ return -1;
+
if (template[0] != '/')
strcpy(tempname, tempdir);
else
--
1.5.4.19.gd3dfd
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Handle unusual results from find_tempdir.
2008-02-05 12:13 [PATCH] Handle unusual results from find_tempdir Jim Meyering
@ 2008-02-05 15:35 ` Theodore Tso
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Tso @ 2008-02-05 15:35 UTC (permalink / raw)
To: Jim Meyering; +Cc: linux-ext4
On Tue, Feb 05, 2008 at 01:13:04PM +0100, Jim Meyering wrote:
> An alternative: make find_tempdir set tempdir to default_tempdir
> upon malloc failure.
>
> * arch/um/os-Linux/mem.c (make_tempfile): Handle NULL tempdir.
> Don't let a long tempdir (e.g., via TMPDIR) provoke heap corruption.
This wasn't meant for the linux-ext4 list, was it? I think maybe you
typo'ed the mailing list this patch was supposed to be sent to?
Regards,
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-05 15:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-05 12:13 [PATCH] Handle unusual results from find_tempdir Jim Meyering
2008-02-05 15:35 ` Theodore Tso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).