Re: [PATCH, E2FSPROGS] blkid: Automatically chose between ext4 and ext4dev as appropriate

[Andreas Dilger <adilger@sun.com>]

On Feb 08, 2008  17:35 -0500, Theodore Ts'o wrote:
> I plan to release this in an upcoming 1.40.6 release, along with code
> that allows "tune2fs -E test_fs" to work on ext4 filesystems.  The idea
> is that if I can get this into community distro's, it will make it
> easier for them to experiment with ext4/ext4dev, with the appropriate
> forward compatibility when sometime (hopefully 2.6.26 or 2.6.27?) we
> rename ext4dev to ext4.
> 
> Any comments before I push this change out to the maint branch?
> 
> 						- Ted
> 
> 
> @@ -158,6 +159,109 @@ static void get_ext2_info(blkid_dev dev, struct blkid_magic *id,
>  		blkid_set_tag(dev, "SEC_TYPE", "ext2", sizeof("ext2"));
>  }
>  
> +/*
> + * Check to see if a filesystem is in /proc/filesystems.
> + * Returns 1 if found, 0 if not
> + */
> +int fs_proc_check(const char *fs_name)
> +{
> +}

Sure.

> +int check_for_modules(const char *fs_name)
> +{
> +}

This part is quite fragile IMHO.  Why not blindly do an attempt to load
this module via the equivalent of system("modprobe %s", fs_name) and then
call fs_proc_check() to see if it is available?  That removes all of the
kernel/module knowlege/complexity from blkid.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.