Re: [PATCH] e2fsprogs: error checking in blkid/devname.c

Theodore Tso
2008-02-22T18:23:22Z

On Fri, Feb 22, 2008 at 10:52:36AM -0600, Eric Sandeen wrote:
> Theodore Tso wrote:
> > On Fri, Feb 22, 2008 at 10:16:53AM -0600, Eric Sandeen wrote:
> >> From a quick chat with agk, it sounds like outright failure is
> >> appropriate. Sounds like most of the calls fail for reasons like ENOMEM
> >> (but it might be nice if it returned that, eh?)
> >
> > So the question then is why is it that Phillip was able to seeing
> > failures when he was creating and deleting snapshots?
> >
> > I don't mind having blkid return a failure, but it may not fix
> > Phillip's scenario which he listed in BZ #433857; yeah, he won't have
> > a core dump, which is good, but it might mean that some or all of the
> > dm volumes disappear from the blkid results.
>
> Maybe a device-mapper bug is in order :)

Yep, especially if it can be easily reproduced.

- Ted