From: Christoph Hellwig <hch@infradead.org>
To: Duane Griffin <duaneg@dghda.com>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Theodore Tso <tytso@mit.edu>,
sct@redhat.com, akpm@linux-foundation.org, adilger@clusterfs.com
Subject: Re: [RFC, PATCH 4/6] jbd: refactor nested journal log recovery loop into separate functions
Date: Sat, 8 Mar 2008 09:53:51 -0500 [thread overview]
Message-ID: <20080308145351.GB18522@infradead.org> (raw)
In-Reply-To: <8644b32ddec999bbc1da0ac55ad7b66d0b8176de.1204685366.git.duaneg@dghda.com>
On Thu, Mar 06, 2008 at 01:59:12AM +0000, Duane Griffin wrote:
> +static int replay_data_block(
> + journal_t *journal, struct buffer_head *obh, char *data,
> + int flags, unsigned long blocknr)
quite odd formatting, this should be more like:
static int replay_data_block(journal_t *journal, struct buffer_head *obh,
char *data, int flags, unsigned long blocknr)
(same for the other new helpers)
next prev parent reply other threads:[~2008-03-08 14:53 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 1:59 [RFC, PATCH 0/6] ext3: do not modify data on-disk when mounting read-only filesystem Duane Griffin
[not found] ` <a047dfbd7855d5f484ae8a3434f6a073302505be.1204685366.git.duaneg@dghda.com>
2008-03-06 1:59 ` [RFC, PATCH 1/6] jbd: eliminate duplicated code in revocation table init/destroy functions Duane Griffin
2008-03-06 1:59 ` Duane Griffin
[not found] ` <7fbb2f28dcb417e3173ffacc103932c36683f2f0.1204685366.git.duaneg@dghda.com>
2008-03-06 1:59 ` [RFC, PATCH 2/6] jbd: replace potentially false assertion with if block Duane Griffin
2008-03-06 1:59 ` Duane Griffin
2008-03-08 14:52 ` Christoph Hellwig
[not found] ` <bd11bfe0ae59094e7a3fbd813dfd877f989f122f.1204685366.git.duaneg@dghda.com>
2008-03-06 1:59 ` [RFC, PATCH 3/6] jbd: only create debugfs entries if cache initialisation is successful Duane Griffin
2008-03-06 1:59 ` Duane Griffin
[not found] ` <7f095bf2403465433796f2f7aab20f1c9a2e0f73.1204685366.git.duaneg@dghda.com>
2008-03-06 1:59 ` [RFC, PATCH 5/6] jbd: add support for read-only log recovery Duane Griffin
2008-03-06 1:59 ` Duane Griffin
2008-03-11 15:05 ` Jan Kara
2008-03-12 1:40 ` Duane Griffin
2008-03-12 10:51 ` Jan Kara
[not found] ` <f4577a0cc4262de0fbff02cae3858d2e2edfaaea.1204685366.git.duaneg@dghda.com>
2008-03-06 1:59 ` [RFC, PATCH 6/6] ext3: do not write to the disk when mounting a dirty read-only filesystem Duane Griffin
2008-03-06 1:59 ` Duane Griffin
2008-03-06 7:17 ` Andreas Dilger
2008-03-06 11:19 ` Duane Griffin
2008-03-11 15:11 ` Jan Kara
2008-03-12 2:42 ` Duane Griffin
2008-03-12 10:53 ` Jan Kara
[not found] ` <8644b32ddec999bbc1da0ac55ad7b66d0b8176de.1204685366.git.duaneg@dghda.com>
2008-03-06 1:59 ` [RFC, PATCH 4/6] jbd: refactor nested journal log recovery loop into separate functions Duane Griffin
2008-03-06 1:59 ` Duane Griffin
2008-03-08 14:53 ` Christoph Hellwig [this message]
2008-03-08 18:40 ` Duane Griffin
2008-03-11 14:35 ` Jan Kara
2008-03-12 1:02 ` Duane Griffin
2008-03-12 10:50 ` Jan Kara
2008-03-06 3:42 ` [RFC, PATCH 0/6] ext3: do not modify data on-disk when mounting read-only filesystem Andrew Morton
2008-03-06 11:20 ` Duane Griffin
2008-03-13 3:22 ` Daniel Phillips
2008-03-13 12:35 ` Duane Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080308145351.GB18522@infradead.org \
--to=hch@infradead.org \
--cc=adilger@clusterfs.com \
--cc=akpm@linux-foundation.org \
--cc=duaneg@dghda.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox