Re: [PATCH 1/4] quota: Quota core changes for quotaon on remount

Jan Kara
2008-03-17T13:17:57Z

On Thu 13-03-08 14:48:02, Andrew Morton wrote:
> On Thu, 13 Mar 2008 14:04:12 +0100
> Jan Kara <jack@suse.cz> wrote:
>
> > +static inline int DQUOT_ON_REMOUNT(struct super_block *sb)
> > +{
> > + int cnt;
> > + int ret = 0, err;
> > +
> > + if (!sb->s_qcop || !sb->s_qcop->quota_on)
> > + return -ENOSYS;
> > + for (cnt = 0; cnt < MAXQUOTAS; cnt++) {
> > + err = sb->s_qcop->quota_on(sb, cnt, 0, NULL, 1);
> > + if (err < 0 && !ret)
> > + ret = err;
> > + }
> > + return ret;
> > +}
> > +
>
> That's about ten times too large to be inlined. Oh well.
Right, will send a cleanup patch. Thanks for spotting this.

> Sometime could you please take a look at uninlining some of the porkier
> functions in quotaops.h, and maybe convert them to lower case?
>
>
> For the latter we can do
>
> #define DQUOT_ON_REMOUNT(sb) dquot_on_remount(sb)
>
> etc, then remove those macros when everything has been converted and we've
> given any out-of-tree filesytem developers time to update, etc.
Good idea. Will do.

Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR