public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitri Monakhov <dmonakhov@openvz.org>
To: linux-ext4@vger.kernel.org
Subject: strange ext{3,4}_settattr logic
Date: Sat, 15 Mar 2008 19:07:32 +0300	[thread overview]
Message-ID: <20080315160731.GA4186@dmon-lap.sw.ru> (raw)

Hello.
I've found what ext3_setattr() code has some strange logic. I'm talking
about truncate path. 

int ext3_setattr(struct dentry *dentry, struct iattr *attr)
{
...
	if (S_ISREG(inode->i_mode) &&
            attr->ia_valid & ATTR_SIZE && attr->ia_size < inode->i_size) {
                handle_t *handle;
<<< This is shrinking case, and according to function comments:
<<< "In particular, we want to make sure that when the VFS
<<< * shrinks i_size, we put the inode on the orphan list and modify
<<< * i_disksize immediately"
<<< we about to write i_disksize. But WHY do we have to do it explicitly?
<<< Later inode_setattr() will call ext3_truncate() which will do it
<<< this work for us.
                handle = ext3_journal_start(inode, 3);
                if (IS_ERR(handle)) {
                        error = PTR_ERR(handle);
                        goto err_out;
                }

                error = ext3_orphan_add(handle, inode);
                EXT3_I(inode)->i_disksize = attr->ia_size;
                rc = ext3_mark_inode_dirty(handle, inode);
                if (!error)
                        error = rc;
                ext3_journal_stop(handle);
        }
        rc = inode_setattr(inode, attr);
<<< Now the most interesting question. What we have to do now in 
<<< case of error? We are in tricky situation. Truncate not happened,
<<< and blocks visible to the user, but i_disksize was already written,
<<< so later memory reclaiming/ read_inode will result in unexpected
<<< updating i_size.
        /* If inode_setattr's call to ext3_truncate failed to get a
         * transaction handle at all, we need to clean up the in-core
         * orphan list manually. */
<<< Following code will remove inode only from in memory(because handle = NULL)
<<< orphan list. Please someone explain me what this lines suppose to do
<<< actually.
        if (inode->i_nlink)
                ext3_orphan_del(NULL, inode);
...
}

             reply	other threads:[~2008-03-15 16:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-15 16:07 Dmitri Monakhov [this message]
2008-03-15 23:05 ` strange ext{3,4}_settattr logic Andreas Dilger
2008-03-15 23:54   ` Andreas Dilger
2008-03-16  0:23     ` Andreas Dilger
2008-03-16 11:39       ` Dmitri Monakhov
2008-03-16 15:22         ` Andreas Dilger
2008-03-16 17:48           ` Dmitri Monakhov
2008-03-17  8:24         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080315160731.GA4186@dmon-lap.sw.ru \
    --to=dmonakhov@openvz.org \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox