linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@MIT.EDU>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [E2FSPROGS, RFC] New mke2fs types parsing
Date: Thu, 20 Mar 2008 16:49:50 -0400	[thread overview]
Message-ID: <20080320204950.GA7991@mit.edu> (raw)
In-Reply-To: <47E2B850.2080801@redhat.com>

On Thu, Mar 20, 2008 at 02:17:36PM -0500, Eric Sandeen wrote:
> Rather than *looking* for extN and size type in the magic first and
> second slots, what if we fill them in there internally, but they will be
> overridden by any other -T options specified.
> 
> Internally, first an extN type is picked up from mkfs.FOO first, or
> defaults fs type if not specified.  Seond, also internally, a size type
> is chosen next from the default size breakpoints.

Yes, this works, as long as we make sure every single filesystem and
size stanza in /etc/mke2fs.conf overrides each other completely.

Hmm.... Actually, as it's currently specified, it's not completely
true that a later parameter completely overrides a later one.  The one
it's not true for is the "features" profile knob, where each specific
filesystem called e2p_edit_features(), so that one particular features
knob is cumulative.

Given that I think my previous proposal of overriding -t is probably
the better one, and concuptally simpler to understand and document.

    	   	    			   	      - Ted

  reply	other threads:[~2008-03-20 20:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-20 14:06 [E2FSPROGS, RFC] New mke2fs types parsing Theodore Ts'o
2008-02-20 18:51 ` Eric Sandeen
2008-02-20 22:20   ` Theodore Tso
2008-02-20 22:28     ` Eric Sandeen
2008-02-21  8:52     ` Andreas Dilger
2008-02-21 13:35       ` Theodore Tso
2008-03-17 21:29     ` Eric Sandeen
2008-03-18  2:20       ` Theodore Tso
2008-03-18  3:23         ` Eric Sandeen
2008-03-18  4:23           ` Theodore Tso
2008-03-18  5:16             ` Eric Sandeen
2008-03-18 11:01               ` Theodore Tso
2008-03-18 13:11                 ` Eric Sandeen
2008-03-18 13:52                   ` Theodore Tso
2008-03-18 16:06                     ` Eric Sandeen
2008-03-20 19:17                     ` Eric Sandeen
2008-03-20 20:49                       ` Theodore Tso [this message]
2008-03-19  3:36                 ` Andreas Dilger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080320204950.GA7991@mit.edu \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).