linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: cmm@us.ibm.com, rmk@arm.linux.org.uk, linux-ext4@vger.kernel.org,
	aneesh.kumar@linux.vnet.ibm.com
Subject: Re: [PATCH] arm: Export needed symbol for ZERO_PAGE usage in modules.
Date: Mon, 24 Mar 2008 12:05:41 -0700	[thread overview]
Message-ID: <20080324120541.04615a2b.akpm@linux-foundation.org> (raw)
In-Reply-To: <1206381689-12600-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>

On Mon, 24 Mar 2008 23:31:29 +0530
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:

> ext4 use ZERO_PAGE(0) to zero out blocks. We need to export
> different symbols in different arch for the usage of ZERO_PAGE
> in modules.
> 
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> ---
>  arch/arm/mm/mmu.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
> index d41a75e..2d6d682 100644
> --- a/arch/arm/mm/mmu.c
> +++ b/arch/arm/mm/mmu.c
> @@ -35,6 +35,7 @@ extern pgd_t swapper_pg_dir[PTRS_PER_PGD];
>   * zero-initialized data and COW.
>   */
>  struct page *empty_zero_page;
> +EXPORT_SYMBOL(empty_zero_page);
>  
>  /*

I wonder if it would be better to do this export in generic code.

Architectures which don't implement empty_zero_page:

alpha:		seems to do something fancy
sparc64: 	need to rename mem_map_zero to empty_zero_page
v850:		#define ZERO_PAGE(vaddr) ((void *)0x87654321)  (wtf?)



      reply	other threads:[~2008-03-24 19:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-24 18:01 [PATCH] arm: Export needed symbol for ZERO_PAGE usage in modules Aneesh Kumar K.V
2008-03-24 19:05 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080324120541.04615a2b.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=cmm@us.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).