Kernel patch: ext2 creators list update

Kernel patch: ext2 creators list update

[Pietro Gagliardi]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

Hello. I'm working on a new OS that will have ext2 as the primary  
filesystem. I'm adding my OS to the list of creators, for the  
superblock item s_creator_os. I know the kernel doesn't use these  
values; I don't know if any user programs do, though.


[-- Attachment #2: linux.patch --]
[-- Type: application/octet-stream, Size: 346 bytes --]

--- linux-2.6.24.4/include/linux/ext2_fs.h.orig	2008-03-24 14:49:18.000000000 -0400
+++ linux-2.6.24.4/include/linux/ext2_fs.h	2008-03-28 17:36:55.000000000 -0400
@@ -426,6 +426,7 @@ struct ext2_super_block {
 #define EXT2_OS_MASIX		2
 #define EXT2_OS_FREEBSD		3
 #define EXT2_OS_LITES		4
+#define EXT2_OS_PGOS        5
 
 /*
  * Revision levels

[-- Attachment #3: Type: text/plain, Size: 29 bytes --]



Enjoy!
- Pietro Gagliardi

Re: Kernel patch: ext2 creators list update

[Theodore Tso]

On Fri, Mar 28, 2008 at 05:54:07PM -0400, Pietro Gagliardi wrote:
> Hello. I'm working on a new OS that will have ext2 as the primary
> filesystem. I'm adding my OS to the list of creators, for the
> superblock item s_creator_os. I know the kernel doesn't use these
> values; I don't know if any user programs do, though.

It turns out s_creator_os was a mistake, because there's no sane way
*to* use it.  You want filesystems to be portable across different
operating systems, so using it to change the interpretation of various
fields causes problem for cross-OS compatibility, if you want to mount
an ext2 filesystem created on FreeBSD on Linux, for example.  So at
best it's only good as a non-functional comment and that's about it.

So more support of this field means that people might do things like
what they did with Hurd, which was absolutely the *wrong* way to do
things.  So for example, if you delete files on a Hurd filesystem on
most other operating systems, the other OS's probably won't know to
remove the Hurd's translator block, resulting in a (mostly harmless)
corrupted filesystem because the translator block won't be freed.  So
the s_creator_os simply because an attractive nuisance, that invites
people to do the Wrong Thing.  (They should have used an RO compat
feature flag instead.)

Fortunately, Hurd never got any real popularity, so the fact that the
Linux kernel doesn't currectly Hurd-variant filesystems isn't a big
deal.  But it was clearly a bad mistake on our part.

So actually, what we should do instead is add coments saying that the
use of s_creator_os is deprecated, and gradually reduce the use of it
entirely.  (Hurd will eventually move its the functionality for
storing an inode's "translator" to an extended attribute, at which
point the need for s_creator_os can actually go away completely.)

	       	       	   	  	- Ted