public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@sun.com>
To: "Jose R. Santos" <jrs@us.ibm.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH][TRIVIAL][e2fsprogs] Rename uninit_groups to uninit_bg.
Date: Thu, 10 Apr 2008 10:33:14 -0600	[thread overview]
Message-ID: <20080410163314.GA5693@webber.adilger.int> (raw)
In-Reply-To: <20080402140221.30632.62083.stgit@gara.konoha.net>

On Apr 02, 2008  09:03 -0500, Jose R. Santos wrote:
> Rename uninit_groups to uninit_bg.
> 
> <meta_bg> <flex_bg> <uninit_groups> <lazy_bg>
> 
> One of these things is not like the others,
> One of these things just doesn't belong,
> Can you tell which thing is not like the others
> By the time I finish my song?
>        	    by Joe Raposo

Jose,
I don't disagree with this change, but can you please keep compatibility
with the old name for some time, as we have been using the "uninit_groups"
name for some time already.

> diff --git a/lib/e2p/feature.c b/lib/e2p/feature.c
> index cf37447..3fc4f91 100644
> --- a/lib/e2p/feature.c
> +++ b/lib/e2p/feature.c
> @@ -45,7 +45,7 @@ static struct feature feature_list[] = {
>  	{	E2P_FEATURE_RO_INCOMPAT, EXT4_FEATURE_RO_COMPAT_HUGE_FILE,
>  			"huge_file" },
>  	{	E2P_FEATURE_RO_INCOMPAT, EXT4_FEATURE_RO_COMPAT_GDT_CSUM,
> -			"uninit_groups" },
> +			"uninit_bg" },

I think we just need an additional stanza here after this one which has
the old name in it.  That way lookup-by-value will find uninit_bg, and
lookup-by-name will still work.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.


  reply	other threads:[~2008-04-10 16:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-02 14:03 [PATCH][TRIVIAL][e2fsprogs] Rename uninit_groups to uninit_bg Jose R. Santos
2008-04-10 16:33 ` Andreas Dilger [this message]
2008-04-10 17:05   ` Jose R. Santos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080410163314.GA5693@webber.adilger.int \
    --to=adilger@sun.com \
    --cc=jrs@us.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox