From: Josef Bacik <jbacik@redhat.com>
To: Andreas Dilger <adilger@sun.com>
Cc: Josef Bacik <jbacik@redhat.com>,
linux-ext4@vger.kernel.org, sandeen@redhat.com
Subject: Re: [PATCH] fiemap support for ext3
Date: Thu, 24 Apr 2008 08:36:00 -0400 [thread overview]
Message-ID: <20080424123600.GB25173@unused.rdu.redhat.com> (raw)
In-Reply-To: <20080424025803.GM3095@webber.adilger.int>
On Wed, Apr 23, 2008 at 08:58:03PM -0600, Andreas Dilger wrote:
> On Apr 23, 2008 15:39 -0400, Josef Bacik wrote:
> > Here is my reworked fiemap patch for ext3. The generic fiemap handler
> > takes the get_block_t from the filesystem and does the fiemap that way,
> > so then adding ext2 support should be a snap, as well as any other fs
> > that wants to use this.
>
> Ah, one other point is that this should also be used by ext4 to map inodes
> that are not in extents format, replacing the -EOPNOTSUPP return in that
> case.
>
Sounds good, but I'm wondering if we should add a flag to the FIEMAP stuff to
specify wether the inode you are mapping does truly have extents or if its just
more of a block map. Do you think something like that would be usefull? Thank
you,
Josef
next prev parent reply other threads:[~2008-04-24 12:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 19:39 [PATCH] fiemap support for ext3 Josef Bacik
2008-04-23 23:27 ` Andreas Dilger
2008-04-23 23:48 ` Eric Sandeen
2008-04-24 2:56 ` Andreas Dilger
2008-04-24 2:58 ` Andreas Dilger
2008-04-24 12:36 ` Josef Bacik [this message]
2008-04-24 12:52 ` Eric Sandeen
2008-04-24 12:46 ` Josef Bacik
2008-04-24 14:59 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080424123600.GB25173@unused.rdu.redhat.com \
--to=jbacik@redhat.com \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox