linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: commit a4b69b7f1809898c87bdc11502ca258a8f16a220 breaks parallel builds
Date: Sun, 11 May 2008 20:38:17 -0400	[thread overview]
Message-ID: <20080512003816.GA25012@mit.edu> (raw)
In-Reply-To: <48226C3B.5060007@redhat.com>

On Wed, May 07, 2008 at 09:58:03PM -0500, Eric Sandeen wrote:
> 
> I tried looking into this, but I'm at a bit of a loss as to what the
> change was trying to do, so not sure how to fix it... but from
> e2fsprogs/lib/uuid/ it would appear that the addition of
> $(LIB)/$(LIBRARY).a here has got us backing up one ".." too far :)

Here's the fix which I've checked into the git repository.

       	       	     	  	       	   - Ted

>From b93cb0664e1e118e2d5f6788152cb876ad3f13bc Mon Sep 17 00:00:00 2001
From: Theodore Ts'o <tytso@mit.edu>
Date: Sun, 11 May 2008 20:34:12 -0400
Subject: [PATCH] Fix parallel build problem

Problem was introduced by commit a4b69b7f1809898c87bdc11502ca258a8f16a220

Thanks to Eric Sandeen from Red Hat for pointing out this problem.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
 lib/Makefile.library |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/lib/Makefile.library b/lib/Makefile.library
index 52f28bb..7d9e99f 100644
--- a/lib/Makefile.library
+++ b/lib/Makefile.library
@@ -13,7 +13,7 @@ subdirs:: Makefile
 clean::
 	@$(RM) -f subdirs
 
-$(LIB)/$(LIBRARY).a $(LIBRARY).a: $(OBJS)
+$(LIBRARY).a: $(OBJS)
 	@echo "	GEN_LIB $@"
 	@(if test -r $@; then $(RM) -f $@.bak && $(MV) $@ $@.bak; fi)
 	@$(ARGEN) $@ $(OBJS)
@@ -21,3 +21,4 @@ $(LIB)/$(LIBRARY).a $(LIBRARY).a: $(OBJS)
 	@$(RM) -f ../$@
 	@$(LN) $@ ../$@
 
+$(LIB)/$(LIBRARY).a: $(LIBRARY).a
-- 
1.5.4.1.144.gdfee-dirty


      reply	other threads:[~2008-05-12  3:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-08  2:58 commit a4b69b7f1809898c87bdc11502ca258a8f16a220 breaks parallel builds Eric Sandeen
2008-05-12  0:38 ` Theodore Tso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080512003816.GA25012@mit.edu \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).