From: Andreas Dilger <adilger@sun.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH e2fsprogs] - fix swap sanity tests in blkid, and blkid tests
Date: Tue, 13 May 2008 00:32:12 -0600 [thread overview]
Message-ID: <20080513063212.GF3627@webber.adilger.int> (raw)
In-Reply-To: <48288BEB.6090005@redhat.com>
On May 12, 2008 13:26 -0500, Eric Sandeen wrote:
> One one other required change, though; mkswap requires at least
> 10 pages of swap, so the image needs to be increased to 10x64k
> if mkswap is to succeed...
>
> Maybe it'd be better to just dd it out on the fly?
Probably, yes. Little point in bunzipping bytes that you are just
going to overwrite...
> bunzip2 < $SRCDIR/tests/$i.img.bz2 > tests/tmp/test.img.$$
> + # swap is native-endian, so regenerate before testing
> + if [ "$i" == "swap0" ]; then
> + mkswap -v0 tests/tmp/test.img.$$ > /dev/null
> + elif [ "$i" == "swap1" ]; then
> + mkswap -v1 -L SWAP-TEST -U 8ff8e77f-8553-485e-8656-58be67a81666 tests/tmp/test.img.$$ >/dev/null
> + fi
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
next prev parent reply other threads:[~2008-05-13 6:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 18:26 [PATCH e2fsprogs] - fix swap sanity tests in blkid, and blkid tests Eric Sandeen
2008-05-13 6:32 ` Andreas Dilger [this message]
2008-05-13 12:47 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080513063212.GF3627@webber.adilger.int \
--to=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).