linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruen@suse.de>
To: Tiger Yang <tiger.yang@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH] ext3/4: fix uninitialized bs in ext3/4_xattr_set_handle()
Date: Wed, 14 May 2008 12:56:42 +0200	[thread overview]
Message-ID: <200805141256.43272.agruen@suse.de> (raw)
In-Reply-To: <4828FD68.40608@oracle.com>

On Tuesday 13 May 2008 04:31:04 Tiger Yang wrote:
> Hi, Andrew
>
> This situation only happens we format ext3/4 with inode size more than
> 128 and we have put xattr entries both in ibody and block.
> The consequences about this bug is we will lost the xattr block which
> pointed by i_file_acl with all xattr entires in it. We will alloc a new
> xattr block and put that large value entry in it. The old xattr block
> will become orphan block.

The patch looks good, and it obviously fixes the described problem. Thanks!

Signed-off-by: Andreas Gruenbacher <agruen@suse.de>


Could it please be added to -stable?

Andreas

  parent reply	other threads:[~2008-05-14 10:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-12  3:24 [PATCH] ext3/4: fix uninitialized bs in ext3/4_xattr_set_handle() Tiger Yang
2008-05-13  0:02 ` Andrew Morton
2008-05-13  2:31   ` Tiger Yang
2008-05-13 20:00     ` Andreas Dilger
2008-05-14 10:56     ` Andreas Gruenbacher [this message]
2008-05-14 16:00       ` [stable] " Greg KH
2008-05-14 17:28         ` Andrew Morton
2008-05-14 22:30           ` Theodore Tso
2008-05-14 22:54             ` Andrew Morton
2008-05-13  0:18 ` Eric Sandeen
2008-05-13  7:48   ` Tiger Yang
2008-05-13 12:48     ` Eric Sandeen
2008-05-13  8:48   ` Kalpak Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805141256.43272.agruen@suse.de \
    --to=agruen@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=tiger.yang@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).