linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@sun.com>
To: Bas van Schaik <bas@tuxes.nl>
Cc: Theodore Tso <tytso@MIT.EDU>, linux-ext4@vger.kernel.org
Subject: Re: Scripting e2fsck: no errors, but still exit code 1 "FILE SYSTEM	WAS MODIFIED"
Date: Wed, 21 May 2008 10:14:23 -0600	[thread overview]
Message-ID: <20080521161423.GO3516@webber.adilger.int> (raw)
In-Reply-To: <48334068.1090205@tuxes.nl>

On May 20, 2008  23:19 +0200, Bas van Schaik wrote:
> Theodore Tso wrote:
> > Andreas is right though that if you are taking a proper snapshot, the
> > disk really should be quiesced and no journal replay should be
> > required at all.  That's how a devicemapper snapshot works in LVM ---
> > so one good question to explore is how *are* you doing your snapshots.
>
> Exactly my thoughts, but apparently something is wrong here too. Maybe I
> should note that my journal commit interval is set to something like 5
> or 10 seconds, is that relevant?

No, this is normal.

> Again a small snippet of bash responsible for snapshotting:
> > snapshot_stamp=`date +%Y%m%d-%H%M%S`
> > lvcreate --snapshot --size 50G --name backups-snapshot-$snapshot_stamp
> > $LV &> $TMPLOGFILE
> 
> This is not a weird way to snapshot, is it?

No, this is normal, yet it doesn't seem to work correctly.  Can you please
add some sort of debug message into ext3_write_super_lockfs() and
ext3_unlockfs() to make sure these functions are being called for your
filesystem when you are doing the snapshot.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.


  reply	other threads:[~2008-05-21 16:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-18 10:37 Scripting e2fsck: no errors, but still exit code 1 "FILE SYSTEM WAS MODIFIED" Bas van Schaik
2008-05-18 12:28 ` Theodore Tso
2008-05-18 16:18   ` Bas van Schaik
2008-05-19 11:23     ` Bas van Schaik
2008-05-19 11:32     ` Bas van Schaik
2008-05-20 12:09       ` Theodore Tso
2008-05-20 21:19         ` Bas van Schaik
2008-05-21 16:14           ` Andreas Dilger [this message]
2008-05-20  3:58 ` Andreas Dilger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080521161423.GO3516@webber.adilger.int \
    --to=adilger@sun.com \
    --cc=bas@tuxes.nl \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@MIT.EDU \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).