From: Theodore Tso <tytso@MIT.EDU>
To: Christian Kujau <lists@nerdbynature.de>
Cc: linux-ext4@vger.kernel.org
Subject: Re: bh_count undeclared
Date: Sun, 25 May 2008 19:38:09 -0400 [thread overview]
Message-ID: <20080525233809.GG5970@mit.edu> (raw)
In-Reply-To: <alpine.DEB.1.10.0805251727040.4890@sheep.housecafe.de>
On Sun, May 25, 2008 at 05:35:12PM +0200, Christian Kujau wrote:
> Hi,
>
> while trying to build the current e2fsprogs.pu git tree, I got:
>
> journal.c: In function ‘getblk’:
> journal.c:76: error: ‘bh_count’ undeclared (first use in this function)
>
> When looking at journal.c I see 'bh_count' declared within an #ifdef, but
> even when compiling with --enable-jfs-debug the error persists. Right now I
> just removed the #ifdef so that the build succeeds.
>
> But, what's the real issue here?
Whoops, my bad. I was compiling with --enable-jfs-debug, and I didn't
notice the change I made broke things without that configuration
option.
The right fix is just to surround the bh_count reference with an
#ifdef CONFIG_JBD_DEBUG.
It's part of a quickie mechanism for detecting buffer head leaks,
which (for example) was how I detected a problem in ext4's journal
checksum recovery code. I had made some changes to how it worked
while I was tracking down the problem, and accidentally introduced
that compile time bug. My bad, I'll fix it.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-05-25 23:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-25 15:35 bh_count undeclared Christian Kujau
2008-05-25 23:38 ` Theodore Tso [this message]
2008-05-26 0:19 ` Christian Kujau
2008-05-26 1:05 ` Theodore Tso
2008-05-26 2:00 ` Christian Kujau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080525233809.GG5970@mit.edu \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=lists@nerdbynature.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox