Re: ext4 lock ordering patch

Mingming Cao
2008-05-28T21:08:57Z

On Mon, 2008-05-26 at 19:34 +0200, Jan Kara wrote:
> Hi Mingming,
>
Hi Jan,

> I've noticed you removed the patch reversing locking order of page lock
> and transaction start from ext4 patch queue. Was this because of that
> reported performance problem or for some other reason? As far as I've
> understood that problem has been just in the patch fixing the delalloc mode
> part so just removing that patch would be enough AFAICT.

It was because of the reverse locking handling for delayed allocation.
But we can't just drop the patch fixing the locking order in delalloc
mode part only, we need to drop the whole delalloc or drop the whole
inverse locking patches.

> Anyway, the problem is I have now ordered mode rewrite for JBD2/ext4
> which depends on this patch so the question is how to proceed... Should we
> first fix that delalloc problem (are you looking into that?) or do we merge
> all the changes and then fixup the delalloc code?
>

Aneesh is close to getting lock reserve fixed for delalloc... Let's see.
If that takes too long I think it make sense to merge the new ordered
mode rewrite first then re-think of the delalloc solution based on
reversed locking (rather than fixing around) and the new ordered mode.

Mingming