Re: Ordered mode rewrite for jbd2/ext4

Mingming Cao
2008-06-05T02:40:43Z

On Wed, 2008-06-04 at 17:44 +0200, Jan Kara wrote:
> Hi,
>
> So I've split and ported ordered mode rewrite for ext4+jbd2.
> The core of the rewrite are two patches
>
> jbd2-Implement-data-ordered-mode-handling-via-inode.patch
> ext4-Use-new-framework-for-data-ordered-mode-in-JBD.patch
>
> They also need two trivial fixes:
> vfs-export-filemap_fdatawrite_range.patch
> ext4-Use-new-framework-for-data-ordered-mode-in-JBD.patch
>
> And finally there's a patch removing old ordered mode from jbd2:
> jbd2-Remove-data-ordered-mode-support-using-jbd-buf.patch
>
> I've created the patches to be added to the ext4 patch queue just
> after inversion of page lock and transaction start.
>
> I have refreshed the following patches in the ext4 queue to apply cleanly
> and also fixed some typos in them and added one BUG_ON():
>
> ext4-delalloc-sync-hang-with-journal-lock-inverse-fix.patch
> ext4-delalloc-inverse-jbd-and-page-lock-ordering.patch
> ext4-inverse-jbd-and-page-locking-order.patch
>
> Finally, I've rewritten checks in writepage so
> ext4-Add-validation-to-jbd-lock-inversion-patch-and.patch
> should be replaced with
> ext4-add-checks-to-writepage
>
> as we spoke about it with Aneesh.
>
> All the patches are attached and I'll also post the new ones separately for
> more convenient review. The tests for 4k blocksize run fine for me. The
> kernel oopses for 1k blocksize because of a problem in ext4_page_mkwrite()
> - I'll post that in a separate mail. If noone objects, patches can be added
> to ext4 patch queue.
>

Thanks!

I have added the patches to the patch queue, will take a close look
later.

Regards,
Mingming
> Honza