From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: + ext2-dont-inherit-inappropriate-inode-flags-from-parent.patch added to -mm tree Date: Wed, 4 Jun 2008 22:37:03 -0700 Message-ID: <20080604223703.6f07f962.akpm@linux-foundation.org> References: <200806050437.m554bqsc025546@imap1.linux-foundation.org> <20080605053043.GO2961@webber.adilger.int> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: duaneg@dghda.com, linux-ext4@vger.kernel.org To: Andreas Dilger Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:41337 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751713AbYFEFhI (ORCPT ); Thu, 5 Jun 2008 01:37:08 -0400 In-Reply-To: <20080605053043.GO2961@webber.adilger.int> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Wed, 04 Jun 2008 23:30:43 -0600 Andreas Dilger wrote: > On Jun 04, 2008 21:37 -0700, Andrew Morton wrote: > > +/* Flags that should be inherited by new inodes from their parent. */ > > +#define EXT2_FL_INHERITED ~(EXT2_DIRTY_FL | EXT2_ECOMPR_FL | EXT2_BTREE_FL |\ > > + EXT2_INDEX_FL | EXT2_IMAGIC_FL | EXT2_TOPDIR_FL) > > This doesn't make things much better, unless it is just as a stop-gap > measure to get into the kernel while there is more discussion about which > flags need to be inherited... Duane did mention follow-up patches, so > I have no real objection to this patch as-is, so long as we don't consider > the matter closed. > > Minor nit - "EXT2_BTREE_FL" is the long-deprecated name for "EXT2_INDEX_FL", > so we may as well just avoid it entirely here. > > Yes, this patch avoids a few more of the cases that are bad, but will > again be incorrect as soon as some new flag enters use. > ah, OK, thanks. I'll drop them again pending finalisation of all this.