From: Theodore Tso <tytso@mit.edu>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: cmm@us.ibm.com, sandeen@redhat.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH -v2] ext4: Use inode preallocation with -o noextents
Date: Wed, 4 Jun 2008 23:22:20 -0400 [thread overview]
Message-ID: <20080605032220.GC10488@mit.edu> (raw)
In-Reply-To: <20080604040101.GA22348@skywalker>
when I moved this patch to the beginning of the unstable patch queue,
it didn't apply. When I tried to look at it, my head started
spinning. The patch applied to the wrong function, apparently,
because there is so much code duplication "patch" got confused. I
can't blame it, though, because *I* got confused.
fs/ext4/balloc.c is a complete disaster right now. We have:
ext4_new_blocks_old()
ext4_new_meta_block()
ext4_new_meta_blocks()
ext4_new_blocks()
... and without any comments, it is extremely impenetrable. Someone
needs to document what the heck all of the various functions have to
do with each other, when they get used (i.e., with which mount options).
Why aren't we factoring out the last three into a single function?
- Ted
next prev parent reply other threads:[~2008-06-05 3:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-19 20:34 [PATCH -v2] ext4: Use inode preallocation with -o noextents Aneesh Kumar K.V
2008-06-04 2:23 ` Theodore Tso
2008-06-04 4:01 ` Aneesh Kumar K.V
2008-06-05 3:22 ` Theodore Tso [this message]
2008-06-05 8:43 ` Aneesh Kumar K.V
2008-06-05 14:55 ` Mingming Cao
2008-06-05 18:24 ` Andreas Dilger
2008-06-05 18:46 ` Aneesh Kumar K.V
2008-06-06 21:33 ` Mingming Cao
2008-06-11 3:26 ` Shen Feng
2008-06-12 9:34 ` Andreas Dilger
2008-06-12 13:41 ` Eric Sandeen
2008-06-11 3:44 ` Shen Feng
2008-06-16 3:41 ` Shen Feng
2008-06-17 9:42 ` Shen Feng
2008-06-17 10:48 ` Aneesh Kumar K.V
2008-06-18 1:43 ` Shen Feng
2008-06-05 15:37 ` Theodore Tso
2008-06-05 18:28 ` Andreas Dilger
2008-06-05 19:12 ` Aneesh Kumar K.V
2008-06-05 20:58 ` Andreas Dilger
2008-06-06 16:26 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080605032220.GC10488@mit.edu \
--to=tytso@mit.edu \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).