Re: + ext2-dont-inherit-inappropriate-inode-flags-from-parent.patch added to -mm tree

Andreas Dilger
2008-06-05T05:30:47Z

On Jun 04, 2008 21:37 -0700, Andrew Morton wrote:
> +/* Flags that should be inherited by new inodes from their parent. */
> +#define EXT2_FL_INHERITED ~(EXT2_DIRTY_FL | EXT2_ECOMPR_FL | EXT2_BTREE_FL |\
> + EXT2_INDEX_FL | EXT2_IMAGIC_FL | EXT2_TOPDIR_FL)

This doesn't make things much better, unless it is just as a stop-gap
measure to get into the kernel while there is more discussion about which
flags need to be inherited... Duane did mention follow-up patches, so
I have no real objection to this patch as-is, so long as we don't consider
the matter closed.

Minor nit - "EXT2_BTREE_FL" is the long-deprecated name for "EXT2_INDEX_FL",
so we may as well just avoid it entirely here.

Yes, this patch avoids a few more of the cases that are bad, but will
again be incorrect as soon as some new flag enters use.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.