public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Mingming Cao <cmm@us.ibm.com>, Theodore Tso <tytso@mit.edu>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: Patches for the patchqueue
Date: Thu, 5 Jun 2008 15:23:50 +0530	[thread overview]
Message-ID: <20080605095350.GG8942@skywalker> (raw)
In-Reply-To: <20080605095158.GF8942@skywalker>

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: 003-delalloc-clear-bh-delay-bit-fix.patch --]
[-- Type: text/x-diff, Size: 863 bytes --]

vfs: Don't flush delay buffer to disk

From: Mingming Cao <cmm@us.ibm.com>

In block_write_full_page() error case, we need to check the
delayed flag before flush bh to disk when trying to recover from
error.

Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---

 fs/buffer.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)


diff --git a/fs/buffer.c b/fs/buffer.c
index 2f86ca5..26dddac 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -1775,7 +1775,8 @@ static int __block_write_full_page(struct inode *inode, struct page *page,
 	bh = head;
 	/* Recovery: lock and submit the mapped buffers */
 	do {
-		if (buffer_mapped(bh) && buffer_dirty(bh)) {
+		if (buffer_mapped(bh) && buffer_dirty(bh)
+			&& !buffer_delay(bh)) {
 			lock_buffer(bh);
 			mark_buffer_async_write(bh);
 		} else {

  reply	other threads:[~2008-06-05  9:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-05  9:50 Patches for the patchqueue Aneesh Kumar K.V
2008-06-05  9:51 ` Aneesh Kumar K.V
2008-06-05  9:53   ` Aneesh Kumar K.V [this message]
2008-06-05  9:55     ` Aneesh Kumar K.V
2008-06-05 18:02       ` Mingming Cao
2008-06-05 18:59         ` Aneesh Kumar K.V
2008-06-05 18:51     ` Andreas Dilger
  -- strict thread matches above, loose matches on Subject: below --
2008-06-06 18:24 Aneesh Kumar K.V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080605095350.GG8942@skywalker \
    --to=aneesh.kumar@linux.vnet.ibm.com \
    --cc=cmm@us.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox