Re: [PATCH -v2] ext4: Use inode preallocation with -o noextents

["Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>]

On Thu, Jun 05, 2008 at 12:24:55PM -0600, Andreas Dilger wrote:
> On Jun 05, 2008  07:55 -0700, Mingming Cao wrote:
> > >  /**
> > > - * ext4_new_blocks_old() -- core block(s) allocation function
> > > + * ext4_orlov_new_blocks() -- core block(s) allocation function
> > 
> > what is orlov means? this is core function for non extent based without
> > mballoc block allocation, right? 
> 
> Orlov is the name of the INODE allocator, not the block allocator.  I'm
> not sure there is a name for the block allocator except "old" or "bitmap".

What do you suggest to rename it as ?  I actually got the name from
http://lwn.net/Articles/14633/. But since the old allocator the block
location depends more closely on where the inodes are place i guess we
can name even the block as orlov allocator.


> In the future I suspect we won't want to keep this version at all, using
> the mballoc allocator even for block-mapped files, but it is useful for
> now for performance comparisons.
> 

The patch which is marked in the subject is exactly doing that.


-aneesh